linux-mips
[Top] [All Lists]

Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().

To: Shane McDonald <mcdonald.shane@gmail.com>, ralf@linux-mips.org
Subject: Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 13 Jun 2012 09:29:50 -0700
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=uj1zW4/Xod6LsWq/3qCr+g3Jkc5IlGMtrjWr8pRya48=; b=Jms8gauzbsmdMNkpric0j3ow6YhCl3tWQwu+Etd7whksrbLBknQ7dKglSiTaq8xNu2 TaCVVJFGRj9lTOw67rRQ4+vUKwJ+gvT+/iw9t3qcbCQfhBTRLz1B3mlb7+K6MIqGnTu0 ErwxQ1iTjOnxSuSbOrE9sTpAKeqCPpaWTcUttky9b+I9zqwCpr/bs6WvzJ+UWt9nmE/l 4VuCvP0CvYtvUUHGNTnRcXduKQUIG7dDI0GYkCWXtovila7PAm1rN84E7zO53NE+0PUo Rh/Oh9CHCaquWaMnx9QiaGoh2EnVfXej2Gwi13DKjOEox9iO8lOw24GpgqrGGNiR0/n/ l6Qg==
In-reply-to: <CACoURw6S+Z9urgYQzqkTZ0WR4kcaxMnSLm=D6m_6pWJnvDtUpA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337040290-16015-1-git-send-email-ddaney.cavm@gmail.com> <1337040290-16015-6-git-send-email-ddaney.cavm@gmail.com> <CACoURw4+N8Nk-N81kryXHOg9O_=ntvqv9prOLAZW6KKEYQ9v+A@mail.gmail.com> <4FD61B22.3040407@gmail.com> <4FD61F35.1080103@gmail.com> <CACoURw6oCNKHh7o9N_kE6uryfpu57sQqA-p2fq6hKnsikO5KgA@mail.gmail.com> <CACoURw6S+Z9urgYQzqkTZ0WR4kcaxMnSLm=D6m_6pWJnvDtUpA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 06/13/2012 08:44 AM, Shane McDonald wrote:
On Mon, Jun 11, 2012 at 12:32 PM, Shane McDonald
<mcdonald.shane@gmail.com>  wrote:
There is a line:

__setup("cca=", cca_setup);

that seems to be used to call cca_setup().  I don't know how
the __setup() works, so I'm a little lost on the solution myself.

Note that, besides the cca_setup(), there is also a routine
setcoherentio() that is defined the same way as cca_setup().
I suspect that suffers from the same problem as cca_setup().

I've been doing a little learning on how the __setup() macro works.
A proposed solution I have is to change from using the __setup()
macro to using early_param() to mark the call to cca_setup().

This is the exact change I was going to suggest.

Functions marked with __setup() are executed late in the boot
process, whereas those marked with early_param() occur
very early in the process.  I have tried this out,
and it solves my problem, but I'm looking for feedback on
whether this is the correct solution.

Unless I get any different feedback, I'll send out a patch with
my change later today.

Assuming that such a patch passes checkpatch.pl and is otherwise clean, you could add:

Acked-by: David Daney <david.daney@cavium.com>


<Prev in Thread] Current Thread [Next in Thread>