linux-mips
[Top] [All Lists]

Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Wed, 13 Jun 2012 09:44:49 -0600
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=JJHKNhjjIrkG3SL7Z2zh/Zq3rWHwJyB1CiR/FCvXxkU=; b=Mu/XRgXamk1qDl3DvZKmgLO/M37TV8Pn6OUaZNKhvSAGKzn/K7Hml6P9oqQH1075Xh zqCAS8MfgMR1Tg77aXuGQC0GV/j/K/Ixj8OjdfAgUP1OMlsUmR1J9GlkVFiyyZhOTzYg EIPbUvmEGKjJBpixjXrfC79HeQLks6dIwdFpsgo3cY0wETKgtPxFIFsO4ZSNeL2Ht9Qu TUyMC8/hRN4AUlBLpb0b8aAW3pAlpNp99dZWDm53xjxSQCvz1y5COo6cZ6Zoku8s65Lw S23jzLEpfRrcDIfkiJSZS562HwwxdZMhKHnQfQzdxoyu2PchLAbjmiJMgJuZA6OFSjAB 3KSA==
In-reply-to: <CACoURw6oCNKHh7o9N_kE6uryfpu57sQqA-p2fq6hKnsikO5KgA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337040290-16015-1-git-send-email-ddaney.cavm@gmail.com> <1337040290-16015-6-git-send-email-ddaney.cavm@gmail.com> <CACoURw4+N8Nk-N81kryXHOg9O_=ntvqv9prOLAZW6KKEYQ9v+A@mail.gmail.com> <4FD61B22.3040407@gmail.com> <4FD61F35.1080103@gmail.com> <CACoURw6oCNKHh7o9N_kE6uryfpu57sQqA-p2fq6hKnsikO5KgA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Jun 11, 2012 at 12:32 PM, Shane McDonald
<mcdonald.shane@gmail.com> wrote:
> There is a line:
>
> __setup("cca=", cca_setup);
>
> that seems to be used to call cca_setup().  I don't know how
> the __setup() works, so I'm a little lost on the solution myself.
>
> Note that, besides the cca_setup(), there is also a routine
> setcoherentio() that is defined the same way as cca_setup().
> I suspect that suffers from the same problem as cca_setup().

I've been doing a little learning on how the __setup() macro works.
A proposed solution I have is to change from using the __setup()
macro to using early_param() to mark the call to cca_setup().
Functions marked with __setup() are executed late in the boot
process, whereas those marked with early_param() occur
very early in the process.  I have tried this out,
and it solves my problem, but I'm looking for feedback on
whether this is the correct solution.

Unless I get any different feedback, I'll send out a patch with
my change later today.

Shane McDonald

<Prev in Thread] Current Thread [Next in Thread>