linux-mips
[Top] [All Lists]

Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: [PATCH v2 5/5] MIPS: Move cache setup to setup_arch().
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 11 Jun 2012 09:39:17 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=QzFOTJJ4hbcRSW1my/7hUKMNZuea2njFJJopNQ05E7A=; b=LNQniiSizxYwE/3E/J09W/H+eA+Af8Qzturnk0m36KDjX7F0AiNDuuJ4mEzJKJk14K NnEJCbK3J4QHIO/px1St2d4jXPzO2iNh26r+JSH84eD7bm+I9jiVsuJvjdZz0d8CN4iR 4tQXg3X71Ui9eh8OydBoe97IDsgiwSR22znA6NiH2os+TSyn+ksHUxwuV0xzgwornG2g 8zdfx15msVDVTK59vU7iRR9BkFAs6pNpWbFEm2Hky5NFxsZUFQijiRIE/jwm6+j9g5hw CHSKSCxnl06iYlEblr1R5JpqpsFLimwyj3dhXIb3fsURftUZsmoK5ku392ldtUaDNIH6 kWIg==
In-reply-to: <4FD61B22.3040407@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337040290-16015-1-git-send-email-ddaney.cavm@gmail.com> <1337040290-16015-6-git-send-email-ddaney.cavm@gmail.com> <CACoURw4+N8Nk-N81kryXHOg9O_=ntvqv9prOLAZW6KKEYQ9v+A@mail.gmail.com> <4FD61B22.3040407@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 06/11/2012 09:21 AM, David Daney wrote:
On 06/10/2012 09:16 PM, Shane McDonald wrote:
I've run into a problem in linux-3.5-rc1, and I've tracked it down
to this patch, MIPS: Move cache setup to setup_arch().,
commit 6650df3c380e0db558dbfec63ed860402c6afb2a.


Are you permitted to describe the problem in any additional detail?

Knowing what type of system is affected and the nature of the problem
would be useful in trying to arrive at a good solution.


OK, for some reason I missed this bit...

[...]

I'm running a single-CPU, PMC-Sierra RM7035C-based system.

Before applying this patch, cca_setup() in arch/mips/mm/c-r4k.c
is called before coherency_setup() (called from rk4_cache_init()).
After applying the patch, it is called afterwards. Because
coherency_setup() relies on cca_setup() properly setting the
variable cca, it won't use the value of cca supplied on the
kernel command line.

I haven't verified it, but I suspect the same problem will occur
with the call to setcoherentio(), also in c-r4k.c.

Unfortunately, I don't have the knowledge to formulate a patch
to this problem, but I wanted to raise the issue.

Shane McDonald



I will think about how to fix it.

David Daney

<Prev in Thread] Current Thread [Next in Thread>