linux-mips
[Top] [All Lists]

Re: [PATCH 12/35] MIPS: jz4740: Cleanup firmware support for the JZ4740

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH 12/35] MIPS: jz4740: Cleanup firmware support for the JZ4740 platform.
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Wed, 06 Jun 2012 14:13:39 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <1338931179-9611-13-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1338931179-9611-1-git-send-email-sjhill@mips.com> <1338931179-9611-13-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4
On 06/05/2012 11:19 PM, Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
> 
> Signed-off-by: Steven J. Hill <sjhill@mips.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
>  arch/mips/jz4740/prom.c |   25 ++-----------------------
>  1 file changed, 2 insertions(+), 23 deletions(-)
> 
> diff --git a/arch/mips/jz4740/prom.c b/arch/mips/jz4740/prom.c
> index 4a70407..c5071ab 100644
> --- a/arch/mips/jz4740/prom.c
> +++ b/arch/mips/jz4740/prom.c
> @@ -20,33 +20,12 @@
>  
>  #include <linux/serial_reg.h>
>  
> -#include <asm/bootinfo.h>
> +#include <asm/fw/fw.h>
>  #include <asm/mach-jz4740/base.h>
>  
> -static __init void jz4740_init_cmdline(int argc, char *argv[])
> -{
> -     unsigned int count = COMMAND_LINE_SIZE - 1;
> -     int i;
> -     char *dst = &(arcs_cmdline[0]);
> -     char *src;
> -
> -     for (i = 1; i < argc && count; ++i) {
> -             src = argv[i];
> -             while (*src && count) {
> -                     *dst++ = *src++;
> -                     --count;
> -             }
> -             *dst++ = ' ';
> -     }
> -     if (i > 1)
> -             --dst;
> -
> -     *dst = 0;
> -}
> -
>  void __init prom_init(void)
>  {
> -     jz4740_init_cmdline((int)fw_arg0, (char **)fw_arg1);
> +     fw_init_cmdline();
>       mips_machtype = MACH_INGENIC_JZ4740;
>  }
>  


<Prev in Thread] Current Thread [Next in Thread>