linux-mips
[Top] [All Lists]

Re: [PATCH 0/5] Add explicit support YAMON firmware.

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH 0/5] Add explicit support YAMON firmware.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 31 May 2012 09:29:44 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1338415855-11401-1-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1338415855-11401-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 30, 2012 at 05:10:50PM -0500, Steven J. Hill wrote:

Now for the nitpicking :-)

ar7_defconfig breaks with:

  CC      arch/mips/ar7/memory.o
/home/ralf/src/linux/upstream-sfr/arch/mips/ar7/memory.c:33:34: fatal error: 
asm/mips-boards/prom.h: No such file or directory
compilation terminated.
make[4]: *** [arch/mips/ar7/memory.o] Error 1

db1000_defconfig, db1200_defconfig, db1300_defconfig and db1550_defconfig
breaks with:

  CC      arch/mips/alchemy/common/prom.o
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c: In function 
‘prom_get_ethernet_addr’:
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c:73:2: error: 
implicit declaration of function ‘prom_getenv’ 
[-Werror=implicit-function-declaration]
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c:73:14: error: 
assignment makes pointer from integer without a cast [-Werror]
cc1: all warnings being treated as errors
make[4]: *** [arch/mips/alchemy/common/prom.o] Error 1


Test build still running - ENEEDMOREHORSEPOWER ;-)  So far
bcm63xx_defconfig, capcella_defconfig and cavium-octeon_defconfig build ok.

>  arch/mips/include/asm/mipsprom.h                   |    2 -

This is the firmware used by the systems built by MIPS Computer Systems Inc.
and a few very old SGI pre-ARC(S) systems, also some by Pyramid,
Siemens-Nixdorf and others.  It has nothing to do with YAMON.

>  .../mips/include/asm/pmc-sierra/msp71xx/msp_prom.h |   26 -------
>  arch/mips/pmc-sierra/msp71xx/msp_prom.c            |   76 +-----------------
>  arch/mips/pmc-sierra/msp71xx/msp_setup.c           |    2 +-

And these use PMON 2000.  That you found possibilities to share code
beyond YAMON's realm is good but infecting non-YAMON platforms with
YAMON headers isn't.  I suggest to gather code that can kind of code
in arch/mips/lib or a new directory arch/mips/fw/lib.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>