linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.

To: David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 30 May 2012 22:27:49 +0100
Cc: "Steven J. Hill" <sjhill@mips.com>, linux-mips@linux-mips.org
In-reply-to: <20120530210141.GH30086@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337891904-24093-1-git-send-email-sjhill@mips.com> <4FC6628F.9060807@cavium.com> <20120530210141.GH30086@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 30, 2012 at 10:01:41PM +0100, Ralf Baechle wrote:

> > On 05/24/2012 01:38 PM, Steven J. Hill wrote:
> > >From: "Steven J. Hill"<sjhill@mips.com>
> > >
> > >Remove usage of the '__attribute__((alias("...")))' hack that aliased
> > >to integer arrays containing micro-assembled instructions. This hack
> > >breaks when building a microMIPS kernel. It also makes the code much
> > >easier to understand.
> > >
> > >Signed-off-by: Steven J. Hill<sjhill@mips.com>
> > 
> > Looks good to (and even works for) me:
> > 
> > Acked-by: David Daney <david.daney@cavium.com>
> 
> I have to admit that the attribute hack was a desperate attempt at
> avoiding the last bit of assembler code for the page functions.  But somehow
> the patch isn't quite ripe yet.  Building malta_defconfig from
> 7a3434a78b36be2d398a46fb505a3196a9df4a60 with this patch applied on top
> I'm getting:
> 
>   MODPOST 413 modules
> ERROR: "copy_page" [fs/fuse/fuse.ko] undefined!
> ERROR: "clear_page" [fs/fuse/fuse.ko] undefined!
> ERROR: "clear_page" [drivers/net/ethernet/toshiba/tc35815.ko] undefined!

And with that fixed (trivial) I'm getting:

  AS      arch/mips/mm/page-funcs.o
arch/mips/mm/page-funcs.S: Assembler messages:
arch/mips/mm/page-funcs.S:29: Warning: .end symbol does not match .ent symbol.
arch/mips/mm/page-funcs.S:48: Warning: .end symbol does not match .ent symbol.
{standard input}: Error: .size expression for clear_page does not evaluate to a 
constant
{standard input}: Error: .size expression for copy_page does not evaluate to a 
constant

  Ralf

<Prev in Thread] Current Thread [Next in Thread>