linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.

To: "Steven J. Hill" <sjhill@mips.com>, ralf@linux-mips.org
Subject: Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.
From: David Daney <david.daney@cavium.com>
Date: Wed, 30 May 2012 11:10:23 -0700
Cc: linux-mips@linux-mips.org
In-reply-to: <1337891904-24093-1-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337891904-24093-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 05/24/2012 01:38 PM, Steven J. Hill wrote:
From: "Steven J. Hill"<sjhill@mips.com>

Remove usage of the '__attribute__((alias("...")))' hack that aliased
to integer arrays containing micro-assembled instructions. This hack
breaks when building a microMIPS kernel. It also makes the code much
easier to understand.

Signed-off-by: Steven J. Hill<sjhill@mips.com>

Looks good to (and even works for) me:

Acked-by: David Daney <david.daney@cavium.com>

---
  arch/mips/mm/Makefile     |    4 +--
  arch/mips/mm/page-funcs.S |   49 +++++++++++++++++++++++++++++++++
  arch/mips/mm/page.c       |   67 ++++++++++++---------------------------------
  3 files changed, 69 insertions(+), 51 deletions(-)
  create mode 100644 arch/mips/mm/page-funcs.S



<Prev in Thread] Current Thread [Next in Thread>