linux-mips
[Top] [All Lists]

Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq di

To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Subject: Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Tue, 29 May 2012 14:52:48 +0800
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, sshtylyov@mvista.com, david.daney@cavium.com, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, axboe@kernel.dk, jeremy.fitzhardinge@citrix.com, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ioR/RRJR6ly/G5UOpXKQQXnLe/VttkoAA+qBXXfV9KU=; b=lG8W8udH+AwGM6uaXrg1KFHsDZ6PxPsOOG877H/wB4Kdf/Kwhbv9akCaAz6/YWT6SA mxkGuFUr919KJD/JwGzHi6tCdZFKyabVSl3K2nvNzI6FiYwxeunMgciFL+AmkDIZ092U /3vcF3Qpod0HdU/8JVjdKjlJIPwLH6WtJV0aUYWyhldt3B/4I4iCipBJTDUp17lcySzZ saD82HuIiPoQt4wX841jRV6AICrNaOStY6N4Gav3CtSZsX5rDUKyIvJJvXT87zETF+vC bjvdYvE/u+AYShOswIFO1KprKuzrQLEKqteihbdLNO3FCbv3yg5IvIjX/XiGoU4QAofN MwQw==
In-reply-to: <4FC369E3.1030901@linux.vnet.ibm.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1337580008-7280-1-git-send-email-yong.zhang0@gmail.com> <1337580008-7280-7-git-send-email-yong.zhang0@gmail.com> <4FBA1B54.3@linux.vnet.ibm.com> <20120522062126.GB12098@zhy> <4FC369E3.1030901@linux.vnet.ibm.com>
Reply-to: Yong Zhang <yong.zhang0@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, May 28, 2012 at 05:34:51PM +0530, Srivatsa S. Bhat wrote:
> No, I think you are right. Sorry for the delay in replying.
> It indeed looks like we need not use ipi_call_lock/unlock() in CPU bringup
> code..
> 
> However, it does make me wonder about this:
> commit 3d4422332 introduced the generic ipi helpers, and reduced the scope
> of call_function.lock and also added the check in
> generic_smp_call_function_interrupt() to proceed only if the cpu is present
> in data->cpumask.
> 
> Then, commit 3b16cf8748 converted x86 to the generic ipi helpers, but while
> doing that, it explicitly retained ipi_call_lock/unlock(), which is kind of
> surprising.. I guess it was a mistake rather than intentional.

Agree. I think it's a mistake(or leftover) too :)

Anyway, let me cook a patch to throw a stone to clear the road.

Thanks,
Yong

<Prev in Thread] Current Thread [Next in Thread>