[Top] [All Lists]

Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

To: Grant Likely <>
Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().
From: David Daney <>
Date: Tue, 22 May 2012 15:49:43 -0700
Cc: "" <>, Rob Herring <>, "" <>, "" <>, "" <>, "" <>, Liam Girdwood <>, Tabi Timur-B04825 <>, Mark Brown <>, Jaroslav Kysela <>, Takashi Iwai <>, "" <>, "" <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=A9WQbWix97FdzmEUd7ROE/P+2Y1sLU9M1I7lvsGUhA4=; b=mvCJyuNw22RPUlo9Yk7eZo1R1Fn2YmAIj0zADqWJqTGNkLNFsPzpWoZYbGOHwwR/WM E6K43WQjVjgPfGlS/JOtUmekQQtIM0E1UyDcM++fYth/5jySg/g/EzaSe02zg1IDJefv ojTe9LnPXUwH+2x/fC+ONgWuv+sNQR7LhDFNcxdJ5hITwWB7CMmPNf05o0ETRxNjMqZ3 V+0QxI+inIwPmqQx5IDHEAw6nTO5nwm55U0l5FbjuqUt4lRM45za/e0EIgaejsqf54Cp B4SCkgXcRrkqDGbxM1qBFSgei1RP0LqxMfQi6/F9ke0e2RH62KxeL/3ufkbHJ25wF80A 6A5A==
In-reply-to: <>
References: <> <> <20120520055436.13AF03E03B8@localhost> <20120520060802.03CE73E03B8@localhost> <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 05/22/2012 01:09 PM, Grant Likely wrote:
On Tue, May 22, 2012 at 1:45 PM, David Daney<>  wrote:
On 05/19/2012 11:08 PM, Grant Likely wrote:

On Sat, 19 May 2012 23:54:36 -0600, Grant
Likely<>    wrote:

On Fri, 11 May 2012 15:05:21 -0700, David Daney<>

From: David Daney<>

When generating MODALIASes, it is convenient to add things like "spi:"
or "i2c:" to the front of the strings.  This allows the standard
modprobe to find the right driver when automatically populating bus
children from the device tree structure.

Add a prefix parameter, and adjust callers.  For
of_register_spi_devices() use the "spi:" prefix.

Signed-off-by: David Daney<>

Applied, thanks.  Some notes below...

Wait... why is this necessary?

Because in of_register_spi_devices() in of_spi.c, you do:


The string passed to request_module() must have the "spi:" prefix.

How about modifying the call to request_module() to include the prefix
also?  I think that would be a simpler change overall.  Would that

It seems to.  I just sent such a patch in a new thread.

David Daney

<Prev in Thread] Current Thread [Next in Thread>