| To: | linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
|---|---|
| Subject: | [PATCH 7/8] MIPS: smp: Warn on too early irq enable |
| From: | Yong Zhang <yong.zhang0@gmail.com> |
| Date: | Mon, 21 May 2012 14:00:07 +0800 |
| Cc: | ralf@linux-mips.org, sshtylyov@mvista.com, david.daney@cavium.com |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=CmDeuBOUT3p8nrzrJm+4uWaeeD6onOicPLscm+V9ZsM=; b=YXpZ7t/jTdzx58rs0eQdNAmbz673fNXuwOkJNoSIeDpUmKbYAMNMUHQn0cUbSUHLEO AYvfXTLrZwRtTE+mu6NTYdxkQWtog2580q3STNaa7GTyJlV0WzUo9t7AYSvweStNt6Cy 1o9Kt7wN90pMZvv65pPO+rq3+1Wd/lkWq3D1S8ROBSpVevqBW8QdlnQAlf9FW20aAHA6 ksK/IAn7cPDwGTRwA1f3DGSoEP5gK6xYDGJjcN+NBMQvxF23g+YO19kLdW2SLJGyl6Ts f7CDyUFTFdgL8uUbCVLCAgvPiXk7IEaL4OubRYFRgRrsEu0xjiQjJ3mL35yv+k2id2j/ i8Tg== |
| In-reply-to: | <1337580008-7280-1-git-send-email-yong.zhang0@gmail.com> |
| References: | <1337580008-7280-1-git-send-email-yong.zhang0@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
From: Yong Zhang <yong.zhang@windriver.com>
Just to catch a potential issue.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: David Daney <david.daney@cavium.com>
---
arch/mips/kernel/smp.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 042145f..4fbafa8 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)
synchronise_count_slave();
+ /*
+ * irq will be enabled in ->smp_finish(), enabling it too early
+ * is dangerous.
+ */
+ WARN_ON_ONCE(!irqs_disabled());
mp_ops->smp_finish();
cpu_idle();
--
1.7.5.4
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled, Yong Zhang |
|---|---|
| Next by Date: | [PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation, Yong Zhang |
| Previous by Thread: | Re: [PATCH 6/8] MIPS: call set_cpu_online() on the uping cpu with irq disabled, Yong Zhang |
| Next by Thread: | [PATCH 8/8] MIPS: sync-r4k: remove redundant irq operation, Yong Zhang |
| Indexes: | [Date] [Thread] [Top] [All Lists] |