linux-mips
[Top] [All Lists]

[PATCH 5/8] MIPS: call ->smp_finish() a little late

To: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] MIPS: call ->smp_finish() a little late
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Mon, 21 May 2012 14:00:05 +0800
Cc: ralf@linux-mips.org, sshtylyov@mvista.com, david.daney@cavium.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=ovFsYjn17+BCIh8SeCkwPw72lgmLEqbZVYPj8jf2Zpk=; b=DX9fAKnLKr4hKoXOrGqzTy4/ouYF0yvWg7h/aNMuUqmNQ9CHcHJpjB64utjjYv2goW QXlDHNEZnCRmklkUupjcu+lsfeokigtav2LadsuozL3J4gxMOrrEClkMGzEciJubzORV HmGJPT1XMrF2p2RP2XyjGkRB/3doAcqKkCklHW+FCC1cdkI8EJ6Iq57hdJOgCSG81Tbs S1ln68uK2Ya+brCJS6CsbtwklaVoVGdmbmaSx/z4m3xcLbLb/yVol8grbb40wF3lOdbd bzzhNhXcWgk+G203gzrzqMOkhiYsj8r20XsYb6lxxLgGDqYe27TjwmmLJpyxmNDdrSXm 90LQ==
In-reply-to: <1337580008-7280-1-git-send-email-yong.zhang0@gmail.com>
References: <1337580008-7280-1-git-send-email-yong.zhang0@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
From: Yong Zhang <yong.zhang@windriver.com>

We have move irq enable to ->smp_finish. Place ->smp_finish() a little
late to prepare for move set_cpu_online() into start_secondary.
And it's not necessary to call cpu_set(cpu, cpu_callin_map) and
synchronise_count_slave() with irq enabled.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: David Daney <david.daney@cavium.com>
---
 arch/mips/kernel/smp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index ba9376b..73a268a 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -122,13 +122,14 @@ asmlinkage __cpuinit void start_secondary(void)
 
        notify_cpu_starting(cpu);
 
-       mp_ops->smp_finish();
        set_cpu_sibling_map(cpu);
 
        cpu_set(cpu, cpu_callin_map);
 
        synchronise_count_slave();
 
+       mp_ops->smp_finish();
+
        cpu_idle();
 }
 
-- 
1.7.5.4


<Prev in Thread] Current Thread [Next in Thread>