linux-mips
[Top] [All Lists]

[V1 PATCH 0/8] patchset focus on MIPS SMP woes

To: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [V1 PATCH 0/8] patchset focus on MIPS SMP woes
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Mon, 21 May 2012 14:00:00 +0800
Cc: ralf@linux-mips.org, sshtylyov@mvista.com, david.daney@cavium.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=SNorlJvzkxMIDeK11vUYJXafsnNsoMRj8j6HUdzEuKM=; b=Bh75Oihh3qwxqG6jXkNMUlDjia0mT+cg37NDMG3uR7jQtKA4wDUMLcMcpaEf957dnI G36a9ycAz1L82j84Ycq0lE6RS76URuhEtb7L6dUit72zidVZY/2eSLlcV6TiUPKlIMPJ IDga2CJR14XENXPzgaIYibJEE7nPXcEuVUWoWnJlI7s3Xt4kGjPPuXlbUFnMIhr/XIrM RjZWJUB9U8GUE1Wg7vBHFrVRl+lqAB1GsNy3kSpBAlYUyqtzhcS1yCx2EN2hcADM1Bgv EvDOT7kO+U2RGdLzTRfA2U//6PUuOxa42umDpFIUo1VfEOWJ+tbqzh/vYlygGmR9pct0 Ma/Q==
Sender: linux-mips-bounce@linux-mips.org
Changes from V0:
  a) Fix grammar and add summary for commit reference; (Sergei Shtylyov)
  b) Collect Acks


Since commit 5fbd036b [sched: Cleanup cpu_active madness] and
commit 2baab4e9 [sched: Fix select_fallback_rq() vs cpu_active/cpu_online],
it's more safe to put notify_cpu_starting() and set_cpu_online() with
irq disabled, otherwise we will have a typical race condition which
above two commits try to resolve:

       CPU1                            CPU2
__cpu_up();
    mp_ops->boot_secondary();
                               start_secondary();
                                 ->init_secondary();
                                   local_irq_enable();
                               <IRQ>
                               do something;
                                     wake up softirqd;
                                     try_to_wake_up();
                                       select_fallback_rq();
                                       /* select wrong cpu */
    set_cpu_online();


This patchset fix the above issue as well as set_cpu_online is
called on the caller cpu.

BTW, I'm only running it on Cavium board because of limited source,
so if anyone is interested to test it on other board, that's great :)

Yong Zhang (8):
  MIPS: Octeon: delay enable irq to ->smp_finish()
  MIPS: BMIPS: delay irq enable to ->smp_finish()
  MIPS: SMTC: delay irq enable to ->smp_finish()
  MIPS: Yosemite: delay irq enable to ->smp_finish()
  MIPS: call ->smp_finish() a little late
  MIPS: call set_cpu_online() on the uping cpu with irq disabled
  MIPS: smp: Warn on too early irq enable
  MIPS: sync-r4k: remove redundant irq operation

 arch/mips/cavium-octeon/smp.c       |    2 +-
 arch/mips/kernel/smp-bmips.c        |   14 +++++++-------
 arch/mips/kernel/smp.c              |   12 +++++++++---
 arch/mips/kernel/smtc.c             |    3 ++-
 arch/mips/kernel/sync-r4k.c         |    5 -----
 arch/mips/pmc-sierra/yosemite/smp.c |    2 +-
 6 files changed, 20 insertions(+), 18 deletions(-)

-- 
1.7.5.4


<Prev in Thread] Current Thread [Next in Thread>