linux-mips
[Top] [All Lists]

Re: [PATCH v2 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH v2 1/2] MIPS: fix/enrich 34K APRP (APSP) functionalities
From: Deng-Cheng Zhu <dczhu@mips.com>
Date: Mon, 21 May 2012 11:23:27 +0800
Cc: John Crispin <john@phrozen.org>, <linux-mips@linux-mips.org>, <kevink@paralogos.com>
In-reply-to: <alpine.LFD.2.00.1205202231400.3701@eddie.linux-mips.org>
References: <1337244680-29968-1-git-send-email-dczhu@mips.com> <1337244680-29968-2-git-send-email-dczhu@mips.com> <4FB4EF81.10005@phrozen.org> <4FB60403.3080700@mips.com> <4FB68FA2.1030404@phrozen.org> <alpine.LFD.2.00.1205202231400.3701@eddie.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.27) Gecko/20120216 Lightning/1.0b2 Thunderbird/3.1.19
On 05/21/2012 05:32 AM, Maciej W. Rozycki wrote:
On Fri, 18 May 2012, John Crispin wrote:

You could introduce a ARCH_HAS_APRP which any platform can then select ?

Hmm... This is a good idea. Maybe the name could be SYS_SUPPORTS_APRP?

You are correct

  What's so Malta-specific in the VPE loader anyway?  It's a CPU feature,
not a board-specific one.

Well, first off, for VPE loader itself, when it comes to CPS we have
vpe_run() that derives from amon_cpu_start() in arch/mips/mti-malta/malta-
amon.c. There is no implementation of amon_cpu_start() on other platforms.
Secondly, I suppose VPE loader works uniquely for APRP, and part of APRP
(such as IRQ related stuff) depends on platform code. So it makes sense
(IMO) to impose the dependency of APRP on the root (VPE loader).


Thanks,

Deng-Cheng


<Prev in Thread] Current Thread [Next in Thread>