linux-mips
[Top] [All Lists]

Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable

To: Yong Zhang <yong.zhang0@gmail.com>
Subject: Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Thu, 17 May 2012 14:55:12 +0400
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, david.daney@cavium.com
In-reply-to: <1337249410-7162-8-git-send-email-yong.zhang0@gmail.com>
References: <1337249410-7162-1-git-send-email-yong.zhang0@gmail.com> <1337249410-7162-8-git-send-email-yong.zhang0@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
Hello.

On 17-05-2012 14:10, Yong Zhang wrote:

From: Yong Zhang<yong.zhang@windriver.com>

Just to catch a potential issue.

   Grammar nitpicking ahead. :-)

Signed-off-by: Yong Zhang<yong.zhang0@gmail.com>
---
  arch/mips/kernel/smp.c |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 042145f..0d48598 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)

        synchronise_count_slave();

+       /*
+        * irq will be enabled in ->smp_finish(), enable it too early

   s/enable/enabling/

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>