linux-mips
[Top] [All Lists]

Re: [RESEND PATCH V2 06/17] MIPS: lantiq: convert dma to platform driver

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [RESEND PATCH V2 06/17] MIPS: lantiq: convert dma to platform driver
From: John Crispin <blogic@openwrt.org>
Date: Tue, 15 May 2012 18:48:05 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <4FB28694.6030300@mvista.com>
References: <1337017363-14424-1-git-send-email-blogic@openwrt.org> <1337017363-14424-6-git-send-email-blogic@openwrt.org> <4FB237EE.5010502@mvista.com> <4FB28694.6030300@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16
On 15/05/12 18:38, Sergei Shtylyov wrote:
> Hello.
>
> On 05/15/2012 03:03 PM, Sergei Shtylyov wrote:
>
>>> Add code to make the dma driver load as a platform device from the
>>> devicetree.
>
>>> Signed-off-by: John Crispin<blogic@openwrt.org>
>>> ---
>>> arch/mips/lantiq/xway/dma.c | 65
>>> ++++++++++++++++++++++++++++--------------
>>> 1 files changed, 43 insertions(+), 22 deletions(-)
>
>>> diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
>>> index b210e93..0dffb94 100644
>>> --- a/arch/mips/lantiq/xway/dma.c
>>> +++ b/arch/mips/lantiq/xway/dma.c
>> [...]
>>> +int __init
>>> +dma_init(void)
>>> +{
>>> + int ret = platform_driver_register(&dma_driver);
>>> +
>>> + if (ret)
>>> + pr_info("ltq_dma : Error registering platfom driver!");
>
>> You forgot '\n'.
>
>    And I didn't notice "platfom" at first. Sorry. :-)
>    Maybe you'll just get rid of the message? ;-)
>
> WBR, Sergei
>
good idea :-)



<Prev in Thread] Current Thread [Next in Thread>