Re: [RESEND PATCH V2 06/17] MIPS: lantiq: convert dma to platform driver

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 05/15/2012 03:03 PM, Sergei Shtylyov wrote:

> > Add code to make the dma driver load as a platform device from the devicetree.
> > Signed-off-by: John Crispin<blogic@openwrt.org>
> > ---
> > arch/mips/lantiq/xway/dma.c | 65 ++++++++++++++++++++++++++++--------------
> > 1 files changed, 43 insertions(+), 22 deletions(-)
> > diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
> > index b210e93..0dffb94 100644
> > --- a/arch/mips/lantiq/xway/dma.c
> > +++ b/arch/mips/lantiq/xway/dma.c
> [...]
> > +int __init
> > +dma_init(void)
> > +{
> > + int ret = platform_driver_register(&dma_driver);
> > +
> > + if (ret)
> > + pr_info("ltq_dma : Error registering platfom driver!");
> You forgot '\n'.
   And I didn't notice "platfom" at first. Sorry. :-)
   Maybe you'll just get rid of the message? ;-)

WBR, Sergei