linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Sun, 13 May 2012 14:08:16 +0200
Cc: Artem Bityutskiy <dedekind1@gmail.com>, David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, MIPS Mailing List <linux-mips@linux-mips.org>, MTD Maling List <linux-mtd@lists.infradead.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=ytdRRn7pEuKBGQzNJZ319PZvoLwhT8DZVb1hT8DWvKs=; b=Rw1L87avCdV9FS4rpNKqKxY9zrYkPYyIUYzGhMM1cYeptUrcMbkJNqmqbOlDF0pmfQ LkFuw6XU5L+cHk/J2u0zFAbZvvbU6iExDsXZM/dqWk57nnnLxNkhLOE3gIXFDAMSqyBp x018QGKEq7I43+a0OmWIyrUVanwSpENg1cBlyltev8atTR7vlROZoLEfcwKYBWpCUH7H EbHE5pKqAsjsqT7Ww8QM4y1czgBnX6Rhfi/OLNchxQsTcKUD6Qhb35QPAy4a3qDxt42V EW2cBwIeaoWgxLyw/p32HUFVlu3Un5T+ELj8hziarQut5s48MqWGrWckusaKpPcBpHik MR5g==
In-reply-to: <alpine.LFD.2.00.1205060950090.3701@eddie.linux-mips.org>
References: <1335534510-12573-1-git-send-email-dedekind1@gmail.com> <4F9AD14E.9060008@gmail.com> <alpine.LFD.2.00.1205060754390.19691@eddie.linux-mips.org> <1336289676.1996.3.camel@koala> <alpine.LFD.2.00.1205060925070.3701@eddie.linux-mips.org> <1336293478.2801.4.camel@brekeke> <alpine.LFD.2.00.1205060950090.3701@eddie.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
Hi,
On 6 May 2012 11:14, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> On Sun, 6 May 2012, Artem Bityutskiy wrote:
>
>> >  And my opinion is based on experience.  Please check the LMO archives for
>> > why Ralf added this option in the first place -- many years ago.  It's
>> > probably recorded in the git repository too (I'm not sure if the option
>> > was added before or after we moved away from CVS, but in any case old
>> > change logs have been imported when our current repo was created).
>>
>> We need to figure out how to make -Werror be applied only when we do not
>> have W=[123].
>
>  Hmm, that sounds better, however has the counter-intuitive side-effect of
> lowering the severity of the warnings that are enabled even without
> W=[123].
>
>  Modern versions of GCC have that selective -Wno-error=foo option and I
> think it should be possible to build the precise list of warnings not to
> choke on locally in arch/mips/Kbuild with little Makefile magic, falling
> back to something sane for older GCC versions (I'm not sure exactly when
> these selective options were added, certainly sometime between 4.1 and
> 4.3).
>
>  This will be a bit imperfect if any of these additional -Wfoo options
> duplicate ones already added to KBUILD_CFLAGS in our top-level Makefile
> (either explicitly or via -Wall), but that's about the best we can do.
> I'll see if I can cook up something quickly.

Hm, how about doing it the other way round, i.e. explicitly enable
which warnings we want to treat as errors with -Werror=foo? That way
we don't lower the severity when W=[123] and new default enabled
warnings in gcc can't break the build any more, just better (or worse
;-) heuristics can.


Jonas

<Prev in Thread] Current Thread [Next in Thread>