linux-mips
[Top] [All Lists]

Re: [PATCH v2] Add MIPS64R2 core support.

To: "Yegoshin, Leonid" <yegoshin@mips.com>
Subject: Re: [PATCH v2] Add MIPS64R2 core support.
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 11 May 2012 22:05:29 +0400
Cc: "Hill, Steven" <sjhill@mips.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>
In-reply-to: <j9ltxtmuep0qhf4mgqhj4du5.1336758301121@email.android.com>
References: <1336717784-853-1-git-send-email-sjhill@mips.com>,<4FAD4B9E.70803@mvista.com> <ajcsenx2bmwqyi5629d3ywgh.1336757525517@email.android.com>,<4FAD4E5C.9040607@mvista.com> <j9ltxtmuep0qhf4mgqhj4du5.1336758301121@email.android.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
Hello.

On 05/11/2012 09:45 PM, Yegoshin, Leonid wrote:

I don't see any advantage in separation of it.

I do. And I certainly do see an advantage of bothering to describe your changes, not just throwing in patch with unclear summary, no changelog at all, doing 3 things at once and then hoping for it to be silently accepted.

Sergei Shtylyov<sshtylyov@mvista.com>  wrote:

Hello.

On 05/11/2012 09:32 PM, Yegoshin, Leonid wrote:

Not exactly - it adds 64R2 support in Malta, plus small verification that build 
kernel could run 32bit binaries.

I don't think it has sense to multiply patches here, there is no sense to have 
this separated.

5KEc is just test-bed.

     Well, rule of thumb is do one thing per patch. You do three. All that
without proper description.

PS: Please stop top-posting.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>