linux-mips
[Top] [All Lists]

Re: [PATCH v3] Revert fixrange_init() limiting to the FIXMAP region.

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH v3] Revert fixrange_init() limiting to the FIXMAP region.
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 11 May 2012 21:19:24 +0400
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Leonid Yegoshin <yegoshin@mips.com>
In-reply-to: <1336755231-5678-1-git-send-email-sjhill@mips.com>
References: <1336755231-5678-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
Hello.

On 05/11/2012 08:53 PM, Steven J. Hill wrote:

From: "Steven J. Hill"<sjhill@mips.com>

This patch refactors 464fd83e841a16f4ea1325b33eb08170ef5cd1f4 and

  Please also specify that commit's summary in parens.

correctly calculates the right length while taking into account
page table alignment by PMD.

Signed-off-by: Leonid Yegoshin<yegoshin@mips.com>
Signed-off-by: Steven J. Hill<sjhill@mips.com>
[...]

diff --git a/arch/mips/mm/pgtable-32.c b/arch/mips/mm/pgtable-32.c
index adc6911..5d27baf 100644
--- a/arch/mips/mm/pgtable-32.c
+++ b/arch/mips/mm/pgtable-32.c
[...]
@@ -51,8 +52,11 @@ void __init pagetable_init(void)
        /*
         * Fixed mappings:
         */
-       vaddr = __fix_to_virt(__end_of_fixed_addresses - 1)&  PMD_MASK;
-       fixrange_init(vaddr, vaddr + FIXADDR_SIZE, pgd_base);
+       vaddr = __fix_to_virt(__end_of_fixed_addresses - 1);
+       /* Calculate real end before alignment. */
+       vend = vaddr + FIXADDR_SIZE;
+       vaddr = vaddr & PMD_MASK;

        vaddr &= PMD_MASK;

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>