linux-mips
[Top] [All Lists]

Re: [PATCH V2 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pi

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V2 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 10 May 2012 15:24:04 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org, Stephen Warren <swarren@wwwdotorg.org>
In-reply-to: <1336652846-31871-2-git-send-email-blogic@openwrt.org>
References: <1336652846-31871-1-git-send-email-blogic@openwrt.org> <1336652846-31871-2-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, May 10, 2012 at 2:27 PM, John Crispin <blogic@openwrt.org> wrote:

> Implement support for pinctrl on lantiq/xway socs. The IO core found on these
> socs has the registers for pinctrl, pinconf and gpio mixed up in the same
> register range. As the gpio_chip handling is only a few lines, the driver also
> implements the gpio functionality. This obseletes the old gpio driver that was
> located in the arch/ folder.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
> This patch is part of a series moving the mips/lantiq target to OF and clkdev
> support. The patch, once Acked, should go upstream via Ralf's MIPS tree.
>
> Changes in V2
> * cleanup select/depends of the relevant Kconfig symbols
> * dont assume that the arry with out MFPs is linearly mapped
> * sane return code checks inside ltq_pinctrl_dt_node_to_map
> * remove 2 calls to pr_err and replace them with calls to dev_err
> * propagate gpio_chips base addr to the gpio_range
> * define the pin count inside the of_device_id.data
> * minor changes to accomodate the pinctrl-falcon driver (more virt pointers
>  and clocks)
> * change from core_initcall_sync to arch_initcall
> * several typos, codestyle and whitespace cleanups
> * use BIT(x) in favour of (1 << x)

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

<Prev in Thread] Current Thread [Next in Thread>