linux-mips
[Top] [All Lists]

Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinct

To: Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support
From: John Crispin <john@phrozen.org>
Date: Tue, 08 May 2012 17:59:33 +0200
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <4FA940F3.4090008@wwwdotorg.org>
References: <1336133919-26525-1-git-send-email-blogic@openwrt.org> <1336133919-26525-4-git-send-email-blogic@openwrt.org> <CACRpkdYJDd84GbKM7r4Xy+d4iOtdD+rJ3kdq-zwVbf_Attj2Gw@mail.gmail.com> <4FA93B97.4070406@wwwdotorg.org> <4FA93E37.70305@phrozen.org> <4FA940F3.4090008@wwwdotorg.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16
>> How about we do the following.
>>
>> config LANTIQ
>>      select PINCTRL
>>
>> config PINCTRL_LANTIQ
>>      def_bool y
>>      depends on LANTIQ
>>
>> config PINCTRL_LANTIQ_XWAY
>>      def_bool y
>>      depends on SOC_TYPE_XWAY
>>
>> This would auto select the right symbols, have all the dependency logic
>> in 1 place and reduce the size of arch/mips/lantiq/Kconfig
> 
> Is it useful to build a kernel for XWAY without pinctrl, once the driver
> is there? That's the main difference between arch/mips/lantiq/Kconfig
> selecting PINCTRL_LANTIQ_XWAY vs that being a def_bool, and hence
> allowing the user to deselect it.
> 

it would not make sense to build an image without.

config LANTIQ and config SOC_TYPE_XWAY should explicitly select the
symbols that they need.


<Prev in Thread] Current Thread [Next in Thread>