[Top] [All Lists]

Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinct

To: Stephen Warren <>
Subject: Re: [PATCH 04/14] OF: pinctrl: MIPS: lantiq: implement lantiq/xway pinctrl support
From: John Crispin <>
Date: Tue, 08 May 2012 17:59:33 +0200
Cc: Linus Walleij <>,,, Ralf Baechle <>
In-reply-to: <>
References: <> <> <> <> <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20111114 Icedove/3.1.16
>> How about we do the following.
>> config LANTIQ
>>      select PINCTRL
>>      def_bool y
>>      depends on LANTIQ
>>      def_bool y
>>      depends on SOC_TYPE_XWAY
>> This would auto select the right symbols, have all the dependency logic
>> in 1 place and reduce the size of arch/mips/lantiq/Kconfig
> Is it useful to build a kernel for XWAY without pinctrl, once the driver
> is there? That's the main difference between arch/mips/lantiq/Kconfig
> selecting PINCTRL_LANTIQ_XWAY vs that being a def_bool, and hence
> allowing the user to deselect it.

it would not make sense to build an image without.

config LANTIQ and config SOC_TYPE_XWAY should explicitly select the
symbols that they need.

<Prev in Thread] Current Thread [Next in Thread>