linux-mips
[Top] [All Lists]

Re: xway_nand does not build

To: John Crispin <blogic@openwrt.org>
Subject: Re: xway_nand does not build
From: Artem Bityutskiy <dedekind1@gmail.com>
Date: Tue, 08 May 2012 14:13:38 +0300
Cc: MIPS Mailing List <linux-mips@linux-mips.org>, MTD Maling List <linux-mtd@lists.infradead.org>
In-reply-to: <4FA8FD24.6060908@openwrt.org>
References: <1336474838.23308.28.camel@sauron.fi.intel.com> <4FA8FD24.6060908@openwrt.org>
Reply-to: dedekind1@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2012-05-08 at 13:01 +0200, John Crispin wrote:
> On 08/05/12 13:00, Artem Bityutskiy wrote:
> > Hi John,
> >
> > I get the following build error when building xway_nand.c:
> >
> > dedekind@blue:~/git/l2-mtd$ make ARCH=mips CROSS_COMPILE=mips-linux-
> >   CHK     include/linux/version.h
> >   CHK     include/generated/utsrelease.h
> >   UPD     include/generated/utsrelease.h
> >   CALL    scripts/checksyscalls.sh
> >   CHK     include/generated/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   CC      kernel/sys.o
> >   LD      kernel/built-in.o
> >   LD      drivers/mtd/nand/nand.o
> >   CC      drivers/mtd/nand/xway_nand.o
> > drivers/mtd/nand/xway_nand.c: In function 'xway_select_chip':
> > drivers/mtd/nand/xway_nand.c:78:3: error: implicit declaration of function 
> > 'ltq_ebu_w32_mask' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> > make[3]: *** [drivers/mtd/nand/xway_nand.o] Error 1
> > make[2]: *** [drivers/mtd/nand] Error 2
> > make[1]: *** [drivers/mtd] Error 2
> > make: *** [drivers] Error 2
> >
> > and I cannot figure out how to fix this. This build failure makes
> > me really unhappy and shame on me I did not notice it before, of
> > course. Would you have a fix?
> 
> Hi,
> 
> I should have spotted this myself infact. I split these patches out of a
> huge series and did infact check that it builds outside the series.
> looks like i missed a define. Would it be possible, that patch 4 of my
> series flows via Ralfs MIPS tree ? That way we dont need to split out a
> single "#define ltq_ebu_w32_mask" out of the bigger MIPS series ?

OK, so I should drop this patch from l2-mtd.git:

commit e4445062be41c27b2a0b4f2e1e770d24b68686f4
Author: John Crispin <blogic@openwrt.org>
Date:   Mon Apr 30 19:30:48 2012 +0200

    mtd: mips: lantiq: add xway nand support
    
    Add NAND support on Lantiq XWAY SoC.
    
    The driver uses plat_nand. As the platform_device is loaded from DT, we need
    to lookup the node and attach our xway specific "struct platform_nand_data"
    to it.
    
    Signed-off-by: John Crispin <blogic@openwrt.org>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Right?

-- 
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>