linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror

To: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sun, 6 May 2012 09:32:17 +0100 (BST)
Cc: David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, MIPS Mailing List <linux-mips@linux-mips.org>, MTD Maling List <linux-mtd@lists.infradead.org>
In-reply-to: <1336289676.1996.3.camel@koala>
References: <1335534510-12573-1-git-send-email-dedekind1@gmail.com> <4F9AD14E.9060008@gmail.com> <alpine.LFD.2.00.1205060754390.19691@eddie.linux-mips.org> <1336289676.1996.3.camel@koala>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Sun, 6 May 2012, Artem Bityutskiy wrote:

> >  I disagree.  People generally don't fix their broken code just because it 
> > triggers warnings.  The cases where GCC is genuinely confused are the 
> > minority -- and even if so, chances are the human reader of that code will 
> > also be.
> 
> Aggressive opinion, nothing more. A patch which fixes the real issue a
> better way would be way more respectful.

 I didn't trigger the issue, so I have nothing to fix.  I would if it was 
me who did.

 And my opinion is based on experience.  Please check the LMO archives for 
why Ralf added this option in the first place -- many years ago.  It's 
probably recorded in the git repository too (I'm not sure if the option 
was added before or after we moved away from CVS, but in any case old 
change logs have been imported when our current repo was created).

  Maciej

<Prev in Thread] Current Thread [Next in Thread>