linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror
From: Artem Bityutskiy <dedekind1@gmail.com>
Date: Sun, 06 May 2012 10:36:59 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, MIPS Mailing List <linux-mips@linux-mips.org>, MTD Maling List <linux-mtd@lists.infradead.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version; bh=JyXRzu0dOWBcfuz1EeIf9gEDV2VNuX3olol0Osvus2g=; b=k6S7aCLtqVUMdMlSSOC8NiPU/nac2OsObp+QvqWV1V1OLNy+SHH3dqtvB4lwq4vAhh 0IV+ATSF+fC0APR9Haqzx3Hn+Rs7OiSXYzgH+wr7U0uII2b92/cjQ1OK23et/KiZrqm0 gDiTcl5feSJXEGPdWYdH5neK3/tGKf/JDfcoLgVojMSP4Xgdf+cjyrVrPABYYJA/lSON HEddswRBYwSK+f3B4iWb1HrtXT4VivBgzO3wK2tYYaqZ1wa5l+N4A7r3KsE8oWf0Jeyn QBsN3u3UCxMMRjnLeOgoDBvpIAUO4r1jEOnIqWAWgRc8yPVQn+K4LdkFp1VVDDlCpID4 8qrg==
In-reply-to: <alpine.LFD.2.00.1205060804400.19691@eddie.linux-mips.org>
References: <1335534510-12573-1-git-send-email-dedekind1@gmail.com> <1335534510-12573-2-git-send-email-dedekind1@gmail.com> <alpine.LFD.2.00.1205060804400.19691@eddie.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 2012-05-06 at 08:06 +0100, Maciej W. Rozycki wrote:
> On Fri, 27 Apr 2012, Artem Bityutskiy wrote:
> 
> > From: Artem Bityutskiy <Artem.Bityutskiy@linux.intel.com>
> > 
> > I cannot build bcm963xx with the standard Kbuild W=1 switch:
> > 
> > arch/mips/bcm63xx/boards/board_bcm963xx.c: At top level:
> > arch/mips/bcm63xx/boards/board_bcm963xx.c:647:5: error: no previous 
> > prototype for 'bcm63xx_get_fallback_sprom' [-Werror=missing-prototypes]
> > cc1: all warnings being treated as errors
> > 
> > This patch removes the gcc switch to make W=1 work. Mips is the only
> > architecture I know which does not build with W=1 and this upsets my aiaiai
> > scripts. And in general, you never know which warnings newer versions of gcc
> > will start emiting so having -Werror by default is not the best idea.
> 
>  If the function has no prototype, then it cannot be reasonably used from 
> outside -- perhaps you meant to mark it static instead?

No, I meant what I meant - MIPS does not build with W=1.

-- 
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>