On Sun, 2012-05-06 at 08:04 +0100, Maciej W. Rozycki wrote:
> On Fri, 27 Apr 2012, David Daney wrote:
>
> > > MIPS build fails with the standard W=1 Kbuild switch with because of the
> > > -Werror gcc switch.
> > >
> > > This patch removes the gcc switch to make W=1 work. Mips is the only
> > > architecture I know which does not build with W=1 and this upsets my
> > > aiaiai
> > > scripts. And in general, you never know which warnings newer versions of
> > > gcc
> > > will start emiting so having -Werror by default is not the best idea.
> > >
> > > Signed-off-by: Artem Bityutskiy<artem.bityutskiy@linux.intel.com>
> >
> > I think the warning messages are enough, we don't need to break things.
>
> I disagree. People generally don't fix their broken code just because it
> triggers warnings. The cases where GCC is genuinely confused are the
> minority -- and even if so, chances are the human reader of that code will
> also be.
Aggressive opinion, nothing more. A patch which fixes the real issue a
better way would be way more respectful.
--
Best Regards,
Artem Bityutskiy
signature.asc
Description: This is a digitally signed message part
|