[Top] [All Lists]

Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror

To: David Daney <>
Subject: Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror
From: "Maciej W. Rozycki" <>
Date: Sun, 6 May 2012 08:04:33 +0100 (BST)
Cc: Artem Bityutskiy <>, Ralf Baechle <>, MIPS Mailing List <>, MTD Maling List <>
In-reply-to: <>
References: <> <>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Fri, 27 Apr 2012, David Daney wrote:

> > MIPS build fails with the standard W=1 Kbuild switch with because of the
> > -Werror gcc switch.
> > 
> > This patch removes the gcc switch to make W=1 work. Mips is the only
> > architecture I know which does not build with W=1 and this upsets my aiaiai
> > scripts. And in general, you never know which warnings newer versions of gcc
> > will start emiting so having -Werror by default is not the best idea.
> > 
> > Signed-off-by: Artem Bityutskiy<>
> I think the warning messages are enough, we don't need to break things.

 I disagree.  People generally don't fix their broken code just because it 
triggers warnings.  The cases where GCC is genuinely confused are the 
minority -- and even if so, chances are the human reader of that code will 
also be.


<Prev in Thread] Current Thread [Next in Thread>