| To: | David Daney <ddaney.cavm@gmail.com> |
|---|---|
| Subject: | Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror |
| From: | "Maciej W. Rozycki" <macro@linux-mips.org> |
| Date: | Sun, 6 May 2012 08:04:33 +0100 (BST) |
| Cc: | Artem Bityutskiy <dedekind1@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, MIPS Mailing List <linux-mips@linux-mips.org>, MTD Maling List <linux-mtd@lists.infradead.org> |
| In-reply-to: | <4F9AD14E.9060008@gmail.com> |
| References: | <1335534510-12573-1-git-send-email-dedekind1@gmail.com> <4F9AD14E.9060008@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Alpine 2.00 (LFD 1167 2008-08-23) |
On Fri, 27 Apr 2012, David Daney wrote: > > MIPS build fails with the standard W=1 Kbuild switch with because of the > > -Werror gcc switch. > > > > This patch removes the gcc switch to make W=1 work. Mips is the only > > architecture I know which does not build with W=1 and this upsets my aiaiai > > scripts. And in general, you never know which warnings newer versions of gcc > > will start emiting so having -Werror by default is not the best idea. > > > > Signed-off-by: Artem Bityutskiy<artem.bityutskiy@linux.intel.com> > > I think the warning messages are enough, we don't need to break things. I disagree. People generally don't fix their broken code just because it triggers warnings. The cases where GCC is genuinely confused are the minority -- and even if so, chances are the human reader of that code will also be. Maciej |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2,4/9] MIPS: Add microMIPS versions of breakpoints, BUG, etc., Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: [PATCH 2/2] MIPS: bcm63xx: kbuild: remove -Werror, Maciej W. Rozycki |
| Previous by Thread: | Re: [PATCH v2,4/9] MIPS: Add microMIPS versions of breakpoints, BUG, etc., Maciej W. Rozycki |
| Next by Thread: | Re: [PATCH 1/2] MIPS: Kbuild: remove -Werror, Artem Bityutskiy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |