linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] MIPS: changes in mm for adding THP

To: Hillf Danton <dhillf@gmail.com>
Subject: Re: [PATCH 2/3] MIPS: changes in mm for adding THP
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 24 Apr 2012 16:31:37 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=kELVyRqwRjlgVG6ZjD0R1eX3og9lUCp1VaOO465b7eQ=; b=I3PMmfZt7K8M01kgUUrc2ge5KAJzVZ+s+zJLNlfGhY6K5TUTREWtGmofTBaZ6p36y8 nrk0tFkDBhtwJPVEgtSwrlyhlNc2c0J6C+ukcfReNALfVh2Ab13ukEY9sWyks4Qd02ue ZRanRzC1/CRImNz89uizrsN5NH05jEzn2Vol62NZUKtoqP3QZSy65GRi0MPBeF2v6mcP a54fby33JSQnCZx5nEMgcDz1fnmzubKhNV8kApq4nUsyt/b+YrdHKzORU7WLab57584p v5Eey4fBAe2/yH6z/7Kw/3HFor3+B8CQxo3/lk5F/iLQN0MwJTI5r1kllE0+fR4vPEqM VyNQ==
In-reply-to: <CAJd=RBBWia26FaPjn5-RvmAy9MBRtF0Bthkc0f7kxEWcFz6=oQ@mail.gmail.com>
References: <CAJd=RBBWia26FaPjn5-RvmAy9MBRtF0Bthkc0f7kxEWcFz6=oQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 11/26/2011 06:39 AM, Hillf Danton wrote:
Based on the current work of huge TLB, no code is added for THP but info gcc
to compile the huge TLB code for THP. That is the second factor why the present
bit is selected.

Signed-off-by: Hillf Danton<dhillf@gmail.com>
---

--- a/arch/mips/include/asm/page.h      Thu Nov 24 21:17:10 2011
+++ b/arch/mips/include/asm/page.h      Sat Nov 26 21:35:51 2011
@@ -33,7 +33,7 @@
  #define PAGE_SIZE     (_AC(1,UL)<<  PAGE_SHIFT)
  #define PAGE_MASK       (~((1<<  PAGE_SHIFT) - 1))

-#ifdef CONFIG_HUGETLB_PAGE
+#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)

This exact sequence happens many times in the patch.

Can we define some symbol (perhaps in page.h) that is set for both of the conditions?

#if defined(CONFIG_HUGETLB_PAGE) || defined(CONFIG_TRANSPARENT_HUGEPAGE)
#define BRFL
#endif
.
.
.

#ifdef BRFL  /* everywhere else */

We of course wouldn't use the name BRFL, but rather something fitting.

With a change like that, I would like to retest the patches and try to get them merged.

David Daney

<Prev in Thread] Current Thread [Next in Thread>