linux-mips
[Top] [All Lists]

Re: [PATCH] scripts: Make sortextable handle relocations.

To: "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] scripts: Make sortextable handle relocations.
From: David Daney <ddaney.cavm@gmail.com>
Date: Fri, 20 Apr 2012 16:14:05 -0700
Cc: David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, Michal Marek <mmarek@suse.cz>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Andrew Morton <akpm@linux-foundation.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NgRZautG9EwdOFSqQdi8l6Cvra7EH0bMBkeYS5/Bwb4=; b=pDz1fl5Zbpi1MnqGHfwkmlb+tn+iBbiDcwtUkUmwekRyuQUu1/zWx3fk1J7yWw32QG ZaazfetzEm8rkrrdqhf5AZaU/cIebyi83l0NBK0CE7Gx4WBr29tN1vg4tPgyHPY3c7hh 3XmzC8hksFjFiEBPuExEZQco90i7rCi13PfdAIsKCvP9RDkLMp6L4ge0+lbYySsSfiqe NVmNZnoeryqBzxuWG3GKIgoCEO9azrhyFspox/LjqTwSa4nDn3AsA3lzfYbnVRo7adoK 7gpg3mjQQ41qypL/s++cmRQ2KEd+cEjzxSTg9cTYgOgMufqJJypBS9WnMyKm/ISWrghC 5Mgg==
In-reply-to: <4F91EA5B.4000803@zytor.com>
References: <1334961679-14562-1-git-send-email-ddaney.cavm@gmail.com> <4F91EA5B.4000803@zytor.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 04/20/2012 03:59 PM, H. Peter Anvin wrote:
On 04/20/2012 03:41 PM, David Daney wrote:
From: David Daney<david.daney@cavium.com>

If there are relocations on the __ex_table section, they must be fixed
up after the table is sorted.

Also use the unaligned safe accessors from tools/{be,le}_byteshift.h

Signed-off-by: David Daney<david.daney@cavium.com>
---

This should address HPA's concerns about the i386 relocations.  The
i386 kernel still boots after the sort, but I don't know how to test
the relocations, but they sure do look nice!  My MIPS64 kernels still
boot too, so that is also good.


Hi...

This works for absolute relocations of the REL type, but not for
relocations of the RELA type nor for non-absolute relocations (moving
those changes the meaning.)

The program explicitly only handles MIPS and x86.

x86_64 and MIPS never have relocations, and x86_32 is always REL, so that is handled

Also x86_32 is only emitting R_386_32 and those are handled.


I think Linus is right and the right thing to do is to switch to using
relative entries in the exception table; I am currently testing a
patchset to do exactly that (on x86).  It also has the benefit of making
the table half the size on x86-64.  Then we can just zero out the
.rel[a]__ex_table section and be done with it.

That's fine.

In any event we want to do build time sorting, this patch improves the original sortextable, so may be worthwhile as purely a cleanup. I wanted to fix the relocation breakage, even if the eventual solution needs to be somewhat different.


The trick, of course, is that sorting a relative table is slightly
different than sorting an absolute table -- the way I'm doing it for the
in-kernel sorter (still needed for modules) is to add the intra-section
offset to each entry (both sides) before sorting, then doing a *signed*
sort, then denormalize again.  Alpha does it differently, with custom
compare and swap routines.

        -hpa



<Prev in Thread] Current Thread [Next in Thread>