[Top] [All Lists]

Re: [PATCH v1 1/5] scripts: Add sortextable to sort the kernel's excepti

To: Sam Ravnborg <>
Subject: Re: [PATCH v1 1/5] scripts: Add sortextable to sort the kernel's exception table.
From: David Daney <>
Date: Fri, 20 Apr 2012 09:49:59 -0700
Cc: David Daney <>, Ralf Baechle <>, Thomas Gleixner <>, Ingo Molnar <>, "H. Peter Anvin" <>,, Linus Torvalds <>, Michal Marek <>,,, Andrew Morton <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7ybbNZ9FPoSKXCcxgV3N05OVN4JQgNS1gcQgFl+hSU0=; b=bduHcLDlXIUYlJ1ubhv45EBffyT8Bk5z+KjVfH3uq2nm//BKPE/aH9Da57duts+2FK 5/w6YUbXyOWAXxsSMN6umIvLV6+nv1aMWFG0oYwzr7ceCWAP6j0MpDNROF2Fwi+gWIW2 ecd2PULSJ2Z9k8Ys7AdIcrCIiH//YPA2naKRrwBAi80wv7G8ljPonWiJMQ220/qwgNgM 1h9LLlzG0XlV5aLe7dUXjQUN2lUoli8ZCYyFixomTgoofryPGe9I5Zxy95XOhpyOj7FC x1nmxoZS1/SrHshw4+iJ4K1agIgiNTQYoRp4vtnqLFZkxPKkSeZC1YgaQMDOe4FGQgGq DeOA==
In-reply-to: <>
References: <> <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 04/20/2012 07:59 AM, Sam Ravnborg wrote:
On Thu, Apr 19, 2012 at 02:59:55PM -0700, David Daney wrote:
From: David Daney<>

Using this build-time sort saves time booting as we don't have to burn
cycles sorting the exception table.

Signed-off-by: David Daney<>
  scripts/.gitignore    |    1 +
  scripts/Makefile      |    1 +
  scripts/sortextable.c |  273 +++++++++++++++++++++++++++++++++++++++++++++++++
  scripts/sortextable.h |  168 ++++++++++++++++++++++++++++++

If there is only a single file including the .h file - then there is no gain.
Just fold it into the .c file.

s/single file/single site/, and I am in complete agreement. However this patch doesn't meet that criterion. In this particular case, there is more to the patch than just the diffstat.

David Daney

<Prev in Thread] Current Thread [Next in Thread>