linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: cavium: Don't enable irq in ->init__secondary()

To: Yong Zhang <yong.zhang0@gmail.com>
Subject: Re: [PATCH] MIPS: cavium: Don't enable irq in ->init__secondary()
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 16 Apr 2012 09:48:14 -0700
Cc: linux-mips@linux-mips.org, Yong Zhang <yong.zhang@windriver.com>, David Daney <ddaney@caviumnetworks.com>, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6tfnrA3Un8x+uyjmL814/qEOmm3qgywao5WjVh3U7qA=; b=zG5sNEDKaEmXUDvP7gs3bPbGikOEzKvxROsB/BZ4y2rruWE/UsJ80/sA/GacGgwzLL qZHgMKXQLJZqHdpwCm2ySN6/Zwqyuj6dnjdwczLboKMd/TfrCFRFfDMDIPUw5mJ/sHdU 6IVTyBTFzh4LQW0oP1cKcDliBrc4Q+sZ3dV32IKkgjL3d2Mv2fBaKrVoXqLxqYwjYsWM f9gdfNiIY5LIPlhRk/zGd5DiLya+HEwt4De6Tvi6JeYc1WpZOmMg350x+yxU8+R2vmdx lxSWWLoEJvZRIKUVLuQO8pBYAYwFN1L9Y10YuTH3Qe5mKrAFwSltagaGKrSourYmARnk beaw==
In-reply-to: <1334561133-19139-1-git-send-email-yong.zhang0@gmail.com>
References: <1334561133-19139-1-git-send-email-yong.zhang0@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 04/16/2012 12:25 AM, Yong Zhang wrote:
From: Yong Zhang<yong.zhang@windriver.com>

Too early to enable irq will break some following action,
such as notify_cpu_starting().

Can you be more specific about what breaks?


I don't get side effect with this patch.

Without this, where do irqs get enabled on the secondary CPUs?


Signed-off-by: Yong Zhang<yong.zhang0@gmail.com>
Cc: David Daney<ddaney@caviumnetworks.com>
Cc: Ralf Baechle<ralf@linux-mips.org>
---
  arch/mips/cavium-octeon/smp.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 97e7ce9..7e65c88 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -185,7 +185,6 @@ static void __cpuinit octeon_init_secondary(void)
        octeon_init_cvmcount();

        octeon_irq_setup_secondary();
-       raw_local_irq_enable();
  }

  /**


<Prev in Thread] Current Thread [Next in Thread>