linux-mips
[Top] [All Lists]

[PATCH] MIPS: cavium: Don't enable irq in ->init__secondary()

To: linux-mips@linux-mips.org
Subject: [PATCH] MIPS: cavium: Don't enable irq in ->init__secondary()
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Mon, 16 Apr 2012 15:25:33 +0800
Cc: Yong Zhang <yong.zhang@windriver.com>, David Daney <ddaney@caviumnetworks.com>, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=3MzNyNr4xQTUP7dLgmpyCSLN8PzfrlQyWicSCM8xi7k=; b=jWbIhmuozsKv0+/RrkIlq8c66yq4X79DbpozK0oo89W5cBHIdi6bZoM+Yo13Aen3l6 O7eMKNl74lNIN7dyOcTlUE7dGhUZlXNSdAqt/q9WVpDc1BLJmhJTH0VFm9TQtZ5cxKPd fCpx4eQqcYm2qfQwhKRrRLCAwXOUad9CMczxTVilgDC9Dn48VVGbaDd56hviLjv4zs0M +Y6+JIA7ZsCF1yXOqAI6LN47NdeuZQD7iGQvDDyIOlQ3T7FWi9Tkqau2MABYl8KpJuOT nyyrIZt8pDW9EULS5E6I7sfUTA9X3ZxceTvpt06gpGTPTgNaWE9kKkMQKO9GyUc3FRrt gyIw==
Sender: linux-mips-bounce@linux-mips.org
From: Yong Zhang <yong.zhang@windriver.com>

Too early to enable irq will break some following action,
such as notify_cpu_starting().

I don't get side effect with this patch.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: David Daney <ddaney@caviumnetworks.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
 arch/mips/cavium-octeon/smp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 97e7ce9..7e65c88 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -185,7 +185,6 @@ static void __cpuinit octeon_init_secondary(void)
        octeon_init_cvmcount();
 
        octeon_irq_setup_secondary();
-       raw_local_irq_enable();
 }
 
 /**
-- 
1.7.5.4


<Prev in Thread] Current Thread [Next in Thread>