linux-mips
[Top] [All Lists]

Re: [PATCH] Revert fixrange_init() limiting to the FIXMAP region.

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH] Revert fixrange_init() limiting to the FIXMAP region.
From: "Yegoshin, Leonid" <yegoshin@mips.com>
Date: Tue, 10 Apr 2012 02:59:23 +0000
Accept-language: en-US
Cc: "Hill, Steven" <sjhill@mips.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>
In-reply-to: <CAJiQ=7A-Bmn9ULb3+YXaXgYTKiHZm1Dbsd-NQBjeL0TLjKAafQ@mail.gmail.com>
References: <1333988075-1289-1-git-send-email-sjhill@mips.com>,<CAJiQ=7A-Bmn9ULb3+YXaXgYTKiHZm1Dbsd-NQBjeL0TLjKAafQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AQHNFmvjyxzTeoUc7kiyOTfHHJfdRZaT0n6A//+Mh9c=
Thread-topic: [PATCH] Revert fixrange_init() limiting to the FIXMAP region.
Sorry, it was a couple of months ago while I worked on HIGHMEM with cache 
aliasing. I got a soak test failure and rollback of this patch helped. Besides 
that it is clearly wrong to add unmodified memory area length to aligned start 
address of that memory. It seems easy to fix but I hadn't time.

- Leonid.


Kevin Cernekee <cernekee@gmail.com> wrote:


On Mon, Apr 9, 2012 at 9:14 AM, Steven J. Hill <sjhill@mips.com> wrote:
> This patch reverts 464fd83e841a16f4ea1325b33eb08170ef5cd1f4 which
> may not take calculate the right length while taking into account
> page table alignment by PMD.

If the logic is incorrect, I'd like to fix it.  Would you be able to
provide a test case that breaks the current head of tree?

Thanks.

<Prev in Thread] Current Thread [Next in Thread>