linux-mips
[Top] [All Lists]

Re: [PATCH 4/5] MIPS: Malta PCI changes for PCI 2.1 compatibility and co

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH 4/5] MIPS: Malta PCI changes for PCI 2.1 compatibility and conflicts.
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 06 Apr 2012 22:12:09 +0400
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, sjhill@realitydiluted.com
In-reply-to: <1333735183-15796-1-git-send-email-sjhill@mips.com>
References: <1333735183-15796-1-git-send-email-sjhill@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
Hello.

On 04/06/2012 09:59 PM, Steven J. Hill wrote:

From: "Steven J. Hill"<sjhill@mips.com>

Turns on PCI 2.1 compatibility for the Malta platform for the
PIIX4 controller. Change start address to avoid conflicts with
the ACPI and SMB devices.

Signed-off-by: Steven J. Hill<sjhill@mips.com>
---
[...]
diff --git a/arch/mips/mti-malta/malta-setup.c 
b/arch/mips/mti-malta/malta-setup.c
index b7f37d4..5f7d113 100644
--- a/arch/mips/mti-malta/malta-setup.c
+++ b/arch/mips/mti-malta/malta-setup.c
@@ -222,3 +222,14 @@ void __init plat_mem_setup(void)
        board_be_init = malta_be_init;
        board_be_handler = malta_be_handler;
  }
+/* Enable PCI 2.1 compatibility in PIIX4 */
+static void __init quirk_dlcsetup(struct pci_dev *dev)
+{
+       u8 odlc, ndlc;

You don't need two variables. And please add an empty line after declaration block.

+       (void) pci_read_config_byte(dev, 0x82,&odlc);
+       /* Enable passive releases and delayed transaction */
+       ndlc = odlc | 7;
+       (void) pci_write_config_byte(dev, 0x82, ndlc);
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_0,
+               quirk_dlcsetup);

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>