linux-mips
[Top] [All Lists]

Re: [PATCH v5 4/4] USB: OHCI: remove old SSB OHCI driver

To: "Hauke Mehrtens" <hauke@hauke-m.de>
Subject: Re: [PATCH v5 4/4] USB: OHCI: remove old SSB OHCI driver
From: "Arend van Spriel" <arend@broadcom.com>
Date: Fri, 16 Mar 2012 10:05:43 +0100
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>, "m@bues.ch" <m@bues.ch>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "zajec5@gmail.com" <zajec5@gmail.com>
In-reply-to: <1331851799-5968-5-git-send-email-hauke@hauke-m.de>
References: <1331851799-5968-1-git-send-email-hauke@hauke-m.de> <1331851799-5968-5-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
On 03/15/2012 11:49 PM, Hauke Mehrtens wrote:
This is now replaced by the new ssb USB driver, which also supports
devices with an EHCI controller.

Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
---
  drivers/usb/host/Kconfig    |    7 +-
  drivers/usb/host/ohci-hcd.c |   21 +----
  drivers/usb/host/ohci-ssb.c |  260 -------------------------------------------
  3 files changed, 7 insertions(+), 281 deletions(-)
  delete mode 100644 drivers/usb/host/ohci-ssb.c

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 2fc5637..00b6fc8 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -373,10 +373,15 @@ config USB_OHCI_HCD_PCI
          If unsure, say Y.

  config USB_OHCI_HCD_SSB
-       bool "OHCI support for Broadcom SSB OHCI core"
+       bool "OHCI support for Broadcom SSB OHCI core (DEPRECATED)"
        depends on USB_OHCI_HCD&&  (SSB = y || SSB = USB_OHCI_HCD)&&  
EXPERIMENTAL
+       select USB_HCD_SSB
+       select USB_OHCI_HCD_PLATFORM
        default n
        ---help---
+         This option is deprecated now and the driver was removed, use
+         USB_HCD_SSB and USB_OHCI_HCD_PLATFORM instead.
+
          Support for the Sonics Silicon Backplane (SSB) attached
          Broadcom USB OHCI core.

Looks fine as it helps transitioning old .config files. Should the select statements be mentioned in the help section, ie. 'using' iso 'use'.

Gr. AvS



<Prev in Thread] Current Thread [Next in Thread>