linux-mips
[Top] [All Lists]

[PATCH 2/2] MIPS: ath79: Use kmemdup rather than duplicating its impleme

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH 2/2] MIPS: ath79: Use kmemdup rather than duplicating its implementation
From: Gabor Juhos <juhosg@openwrt.org>
Date: Wed, 14 Mar 2012 11:28:36 +0100
Cc: linux-mips@linux-mips.org, juhosg@openwrt.org, Thomas Meyer <thomas@m3y3r.de>
In-reply-to: <1331720916-4015-1-git-send-email-juhosg@openwrt.org>
References: <1331720916-4015-1-git-send-email-juhosg@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
From: Thomas Meyer <thomas@m3y3r.de>

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

 arch/mips/ath79/dev-gpio-buttons.c |    4 +---
 arch/mips/ath79/dev-leds-gpio.c    |    4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/mips/ath79/dev-gpio-buttons.c 
b/arch/mips/ath79/dev-gpio-buttons.c
index 4b0168a..366b35f 100644
--- a/arch/mips/ath79/dev-gpio-buttons.c
+++ b/arch/mips/ath79/dev-gpio-buttons.c
@@ -25,12 +25,10 @@ void __init ath79_register_gpio_keys_polled(int id,
        struct gpio_keys_button *p;
        int err;
 
-       p = kmalloc(nbuttons * sizeof(*p), GFP_KERNEL);
+       p = kmemdup(buttons, nbuttons * sizeof(*p), GFP_KERNEL);
        if (!p)
                return;
 
-       memcpy(p, buttons, nbuttons * sizeof(*p));
-
        pdev = platform_device_alloc("gpio-keys-polled", id);
        if (!pdev)
                goto err_free_buttons;
diff --git a/arch/mips/ath79/dev-leds-gpio.c b/arch/mips/ath79/dev-leds-gpio.c
index cdade68..dcb1deb 100644
--- a/arch/mips/ath79/dev-leds-gpio.c
+++ b/arch/mips/ath79/dev-leds-gpio.c
@@ -24,12 +24,10 @@ void __init ath79_register_leds_gpio(int id,
        struct gpio_led *p;
        int err;
 
-       p = kmalloc(num_leds * sizeof(*p), GFP_KERNEL);
+       p = kmemdup(leds, num_leds * sizeof(*p), GFP_KERNEL);
        if (!p)
                return;
 
-       memcpy(p, leds, num_leds * sizeof(*p));
-
        pdev = platform_device_alloc("leds-gpio", id);
        if (!pdev)
                goto err_free_leds;
-- 
1.7.2.1


<Prev in Thread] Current Thread [Next in Thread>