linux-mips
[Top] [All Lists]

Re: [PATCH V2 07/14] MIPS: lantiq: convert gpio_stp driver to clkdev api

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V2 07/14] MIPS: lantiq: convert gpio_stp driver to clkdev api
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 24 Feb 2012 14:46:56 +0400
Authentication-results: mr.google.com; spf=pass (google.com: domain of sshtylyov@mvista.com designates 10.204.148.79 as permitted sender) smtp.mail=sshtylyov@mvista.com
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1330012993-13510-7-git-send-email-blogic@openwrt.org>
References: <1330012993-13510-1-git-send-email-blogic@openwrt.org> <1330012993-13510-7-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
Hello.

On 23-02-2012 20:03, John Crispin wrote:

Update from old pmu_{dis,en}able() to ckldev api.

Signed-off-by: John Crispin<blogic@openwrt.org>
[...]

diff --git a/arch/mips/lantiq/xway/gpio_stp.c b/arch/mips/lantiq/xway/gpio_stp.c
index e6b4809..8e07958 100644
--- a/arch/mips/lantiq/xway/gpio_stp.c
+++ b/arch/mips/lantiq/xway/gpio_stp.c
[...]
@@ -105,7 +108,9 @@ static int ltq_stp_hw_init(void)
         */
        ltq_stp_w32_mask(0, LTQ_STP_ADSL_SRC, LTQ_STP_CON0);

-       ltq_pmu_enable(PMU_LED);
+       clk = clk_get(dev, NULL);
+       WARN_ON(!clk);

   clk_get() returns error, not NULL.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>