Re: [PATCH V2 07/14] MIPS: lantiq: convert gpio_stp driver to clkdev api

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 23-02-2012 20:03, John Crispin wrote:

> Update from old pmu_{dis,en}able() to ckldev api.
> Signed-off-by: John Crispin<blogic@openwrt.org>
[...]

> diff --git a/arch/mips/lantiq/xway/gpio_stp.c b/arch/mips/lantiq/xway/gpio_stp.c
> index e6b4809..8e07958 100644
> --- a/arch/mips/lantiq/xway/gpio_stp.c
> +++ b/arch/mips/lantiq/xway/gpio_stp.c
[...]
> @@ -105,7 +108,9 @@ static int ltq_stp_hw_init(void)
>          */
>         ltq_stp_w32_mask(0, LTQ_STP_ADSL_SRC, LTQ_STP_CON0);
>
> -       ltq_pmu_enable(PMU_LED);
> +       clk = clk_get(dev, NULL);
> +       WARN_ON(!clk);
   clk_get() returns error, not NULL.

WBR, Sergei