linux-mips
[Top] [All Lists]

Re: [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom
From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Sun, 19 Feb 2012 13:14:04 -0600
Authentication-results: mr.google.com; spf=pass (google.com: domain of larry.finger@gmail.com designates 10.42.150.133 as permitted sender) smtp.mail=larry.finger@gmail.com; dkim=pass header.i=larry.finger@gmail.com
Cc: linville@tuxdriver.com, zajec5@gmail.com, b43-dev@lists.infradead.org, linux-mips@linux-mips.org, linux-wireless@vger.kernel.org, arend@broadcom.com, m@bues.ch
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=eKJqMNdNLvCFEw5nWmbuPB6VaDur90ft8idZc7qqeSQ=; b=jTYs0xBAqtlXhDZA5p+2kZgkagWlD+Z+ZdJVsrq4/btFuKvoJ4bKddjk/4D6eu9lsb xaPi4Gz39FqzI/R62Trsjei8UTK0ysm9lAr/oGPvJvlb0THLfI1WFKLjkiXQjX+P6DUJ 7pT8+eSAeSI8yola7DJKAJ+THJLRrk+4ar8kE=
In-reply-to: <1329676345-15856-3-git-send-email-hauke@hauke-m.de>
References: <1329676345-15856-1-git-send-email-hauke@hauke-m.de> <1329676345-15856-3-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0
On 02/19/2012 12:32 PM, Hauke Mehrtens wrote:
There is no 2.4 GHz or 5GHz antenna gain stored in sprom. The sprom
just stores the gain values for antenna 1 and 2 or 1 to 4 for more
recent sprom versions. On old devices antenna 2 was used for 5 GHz wifi.

Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
---
  drivers/net/wireless/b43legacy/phy.c |    2 +-
  drivers/ssb/pci.c                    |   40 ++++++++++++----------------------
  drivers/ssb/pcmcia.c                 |   12 +++------
  drivers/ssb/sdio.c                   |   12 +++------
  include/linux/ssb/ssb.h              |    7 +-----
  5 files changed, 24 insertions(+), 49 deletions(-)

After this patch, I get the warning

drivers/ssb/pci.c: In function ‘sprom_extract_r123’:
drivers/ssb/pci.c:334:5: warning: unused variable ‘gain’ [-Wunused-variable]

I am still testing, but all other patches compile OK.

Larry

<Prev in Thread] Current Thread [Next in Thread>