linux-mips
[Top] [All Lists]

Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev ap

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 17 Feb 2012 20:53:39 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-serial@vger.kernel.org
In-reply-to: <4F3E84B3.1030201@openwrt.org>
References: <1329474800-20979-1-git-send-email-blogic@openwrt.org> <1329474800-20979-8-git-send-email-blogic@openwrt.org> <4F3E90C4.8010904@mvista.com> <4F3E84B3.1030201@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1
Hello.

On 02/17/2012 07:47 PM, John Crispin wrote:

    The comment doesn't match the essence of patch.

sorry

    Why not just clk_get(&pdev->dev, NULL)?

WBR, Sergei

clk_get_sys uses the clkdev lookup table, which is added by this series.

   clk_get() does the same, indirectly.

it makes the clock code consistent throughout the lantiq related files.
we use clk connections other places, which we cannot reference with
clk_get that easily

clkdev assumes you don't need to use connection ID if the clock is bound to be matched by device ID via the lookup table. clk_get() is a common case when using clkdev, that's why your use of clk_get_sys() stands out as something unusual. I'll have to have a look at your lookup tables...

John

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>