| To: | Sergei Shtylyov <sshtylyov@mvista.com> |
|---|---|
| Subject: | Re: [PATCH 2/3] MIPS: lantiq: add vr9 support |
| From: | John Crispin <blogic@openwrt.org> |
| Date: | Fri, 17 Feb 2012 17:50:40 +0100 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <4F3E91B5.5080603@mvista.com> |
| References: | <1329474832-21095-1-git-send-email-blogic@openwrt.org> <1329474832-21095-2-git-send-email-blogic@openwrt.org> <4F3E91B5.5080603@mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110820 Icedove/3.1.12 |
>> +#define SOC_ID_VRX288 0x1C0
>
> Use tabs to indent the value as above.
>
i would have expected checkpatch.pl to complain about this one ?!
>> + } else if (ltq_is_vr9()) {
>
> Where is this defined?
>
was added around 3.1 with the rest of the soc detection code.
you can find it in arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
thx,
John
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, John Crispin |
|---|---|
| Next by Date: | Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, Sergei Shtylyov |
| Previous by Thread: | Re: [PATCH 2/3] MIPS: lantiq: add vr9 support, Sergei Shtylyov |
| Next by Thread: | [PATCH 3/3] MIPS: lantiq: make use of module_platform_driver(), John Crispin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |