linux-mips
[Top] [All Lists]

Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api
From: John Crispin <blogic@openwrt.org>
Date: Fri, 17 Feb 2012 17:47:38 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org
In-reply-to: <4F3E9129.9040704@mvista.com>
References: <1329474800-20979-1-git-send-email-blogic@openwrt.org> <1329474800-20979-10-git-send-email-blogic@openwrt.org> <4F3E9129.9040704@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110820 Icedove/3.1.12
Hi Sergei,
> ( The comment doesn't match the essence of patch. )

> Again, you're doing something different.
>

sorry

>    Why not clk_get(&pdev->dev, NULL)?
>
> WBR, Sergei
>
>

clk_get_sys uses the clkdev lookup table, which is added by this series.
it makes the clock code consistent throughout the lantiq related files.
we use clk connections other places, which we cannot reference with
clk_get that easily

John

<Prev in Thread] Current Thread [Next in Thread>