Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api

linux-mips

Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api

To:	Sergei Shtylyov <sshtylyov@mvista.com>
Subject:	Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api
From:	John Crispin <blogic@openwrt.org>
Date:	Fri, 17 Feb 2012 17:47:38 +0100
Cc:	Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org
In-reply-to:	<4F3E9129.9040704@mvista.com>
References:	<1329474800-20979-1-git-send-email-blogic@openwrt.org> <1329474800-20979-10-git-send-email-blogic@openwrt.org> <4F3E9129.9040704@mvista.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110820 Icedove/3.1.12

Hi Sergei,
> ( The comment doesn't match the essence of patch. )

> Again, you're doing something different.
>

sorry

>    Why not clk_get(&pdev->dev, NULL)?
>
> WBR, Sergei
>
>

clk_get_sys uses the clkdev lookup table, which is added by this series.
it makes the clock code consistent throughout the lantiq related files.
we use clk connections other places, which we cannot reference with
clk_get that easily

John

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 4/9] MIPS: lantiq: convert falcon to clkdev api, (continued) [PATCH 4/9] MIPS: lantiq: convert falcon to clkdev api, John Crispin [PATCH 5/9] MIPS: lantiq: convert dma driver to clkdev api, John Crispin [PATCH 6/9] MIPS: lantiq: convert gpio_stp driver to clkdev api, John Crispin [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, John Crispin Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, Sergei Shtylyov Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, John Crispin Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, Sergei Shtylyov [PATCH 8/9] NET: MIPS: lantiq: convert etop driver to clkdev api, John Crispin [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api, John Crispin Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api, Sergei Shtylyov Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api, John Crispin <=

Previous by Date:	Re: [PATCH 2/3] MIPS: lantiq: add vr9 support, Sergei Shtylyov
Next by Date:	Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api, John Crispin
Previous by Thread:	Re: [PATCH 9/9] WDT: MIPS: lantiq: convert watchdog driver to clkdev api, Sergei Shtylyov
Next by Thread:	[PATCH 1/3] MIPS: lantiq: unify xway prom code, John Crispin
Indexes:	[Date] [Thread] [Top] [All Lists]