linux-mips
[Top] [All Lists]

Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev ap

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 17 Feb 2012 20:39:16 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-serial@vger.kernel.org
In-reply-to: <1329474800-20979-8-git-send-email-blogic@openwrt.org>
References: <1329474800-20979-1-git-send-email-blogic@openwrt.org> <1329474800-20979-8-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1
Hello.

On 02/17/2012 01:33 PM, John Crispin wrote:

Update from old pmu_{dis,en}able() to ckldev api.

   The comment doesn't match the essence of patch.

Signed-off-by: John Crispin<blogic@openwrt.org>
Cc: linux-serial@vger.kernel.org
---
This patch should go via MIPS with the rest of the series.

  drivers/tty/serial/lantiq.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
index 96c1cac..136dae8 100644
--- a/drivers/tty/serial/lantiq.c
+++ b/drivers/tty/serial/lantiq.c
@@ -686,7 +686,7 @@ lqasc_probe(struct platform_device *pdev)
        if (lqasc_port[pdev->id] != NULL)
                return -EBUSY;

-       clk = clk_get(&pdev->dev, "fpi");
+       clk = clk_get_sys("fpi", NULL);

   Why not just clk_get(&pdev->dev, NULL)?

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>