linux-mips
[Top] [All Lists]

Re: [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio
From: John Crispin <blogic@openwrt.org>
Date: Fri, 17 Feb 2012 13:24:16 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <1329474771-20874-5-git-send-email-blogic@openwrt.org>
References: <1329474771-20874-1-git-send-email-blogic@openwrt.org> <1329474771-20874-5-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110820 Icedove/3.1.12
>       ltq_gbit_w32_mask(0, PX_CTL_DMDIO, LTQ_GBIT_P0_CTL);
> @@ -873,6 +870,12 @@ ltq_etop_probe(struct platform_device *pdev)
>                       err = -ENOMEM;
>                       goto err_out;
>               }
> +             if (ltq_gpio_request(&pdev->dev, 42, 2, 1, "MDIO") ||
> +                             ltq_gpio_request(&pdev->dev, 43, 2, 1, "MDC")) {
> +                     dev_err(&pdev->dev, "failed to request MDIO gpios\n");
> +                     err = -ENOMEM;
-EBUSY should go here instead of -ENOMEM


> +                     goto err_out;
> +             }
>       }
>  
>       dev = alloc_etherdev_mq(sizeof(struct ltq_etop_priv), 4);


<Prev in Thread] Current Thread [Next in Thread>