[Top] [All Lists]

Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h

To: Mark Brown <>
Subject: Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
From: Sam Ravnborg <>
Date: Sat, 4 Feb 2012 18:06:32 +0100
Cc: Guan Xuetao <>, Russell King <>, Ralf Baechle <>, Paul Mundt <>, Geert Uytterhoeven <>, Mike Frysinger <>, Haavard Skinnemoen <>, Hans-Christian Egtvedt <>, Grant Likely <>,,,,,,
In-reply-to: <>
References: <>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Feb 04, 2012 at 03:54:39PM +0000, Mark Brown wrote:
> Rather than requiring architectures that use gpiolib but don't have any
> need to define anything custom to copy an asm/gpio.h provide a Kconfig
> symbol which architectures must select in order to include gpio.h and
> for other architectures just provide the trivial implementation directly.

Hi Mark.

There is an even simpler solution.

For each arch that uses asm-generic/gpio.h add a line
to arch/$ARCH/include/asm/Kbuild like this:

    generic-y += gpio.h

This will then make this arch pick up the asm-generic version when
you do #include <asm/gpio.h>.

And you avoid the kconfig games.

iFor the archs which require their own asm/gpio.h file - just
add it to the asm/ dir - and do not add the generic-y assignment.


<Prev in Thread] Current Thread [Next in Thread>