linux-mips
[Top] [All Lists]

[PATCH V2] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH V2] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Sat, 4 Feb 2012 11:07:37 +0100
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>, Florian Fainelli <florian@openwrt.org>, stable@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=5DbAKFYwy9Pcg1BtxsGhRbHPD1tUZtU03iH+TQ8Jsrc=; b=i5r7zPKtsJ/1IEUu/VPcf7UAJ1qqjhOPGM6uDS8gdo230BqkkPGYbYw07gmGvmMuCB tzXt9ygtBWg+mxcW5j+wInsghXbJaQ4N4ZcQxhulukddzgh3DUjpSiR1CetNOhhx7Ivq gHmbuKmmSxfBs7nQpQ5t1gJUZwe9N1KLrGUYE=
Sender: linux-mips-bounce@linux-mips.org
bcm63xx_gpio.h uses macros defined in bcm63xx_cpu.h without including it,
leading to the following build failure:

  CC [M]  drivers/mmc/core/cd-gpio.o
In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
                 from arch/mips/include/asm/gpio.h:4,
                 from include/linux/gpio.h:30,
                 from drivers/mmc/core/cd-gpio.c:12:

arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 
'bcm63xx_gpio_count':
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit 
declaration of function 'bcm63xx_get_cpu_id'
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared 
identifier is reported only once for each function it appears in
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' 
undeclared (first use in this function)

make[7]: *** [drivers/mmc/core/cd-gpio.o] Error 1

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Cc: stable@vger.kernel.org
---
V1 -> V2
 * added cc to stable


This is also needed for all supported stable versions. The include is
missing from the beginning, breaking any driver using linux/gpio.h (but
they don't seem to be used often used on bcm63xx).

 arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h 
b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
index 3d5de96..1d7dd96 100644
--- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
+++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h
@@ -2,6 +2,7 @@
 #define BCM63XX_GPIO_H
 
 #include <linux/init.h>
+#include <bcm63xx_cpu.h>
 
 int __init bcm63xx_gpio_init(void);
 
-- 
1.7.2.5


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH V2] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h, Jonas Gorski <=