linux-mips
[Top] [All Lists]

Re: [Patch] mips: do not redefine BUILD_BUG()

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [Patch] mips: do not redefine BUILD_BUG()
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 3 Feb 2012 11:42:29 +0100
Cc: Cong Wang <xiyou.wangcong@gmail.com>, linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Ralf Baechle <ralf@linux-mips.org>, David Daney <david.daney@cavium.com>, Hillf Danton <dhillf@gmail.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=FVgMbIA1FVppaAdeKfcL31nWUi6EVATjhJvJRaP7aLg=; b=Cjo8tALm0wxf3FKmRHeEtVYOcB+0a2TEC5o2ArPfWSb1JJ8BilwOTlbF22gAKXsGIY xG8eHAroOPRZWVRj+He2CLbJQpdwlm2B4gm1z6vgofGjJn2IyT9ioK84iHCShB2lAzEK iZZygAW6CgPsTWAvslv1OUca/UVMtyfwB+USQ=
In-reply-to: <4F2BB715.8090803@mvista.com>
References: <1328255503-17575-1-git-send-email-xiyou.wangcong@gmail.com> <4F2BB715.8090803@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Feb 3, 2012 at 11:29, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
>> include/linux/kernel.h:717:1: error: "BUILD_BUG" redefined
>> arch/mips/include/asm/page.h:43:1: error: this is the location of the
>> previous definition

>> --- a/arch/mips/include/asm/page.h
>> +++ b/arch/mips/include/asm/page.h
>> @@ -39,9 +39,7 @@
>>  #define HPAGE_MASK    (~(HPAGE_SIZE - 1))
>>  #define HUGETLB_PAGE_ORDER    (HPAGE_SHIFT - PAGE_SHIFT)
>>  #else /* !CONFIG_HUGETLB_PAGE */
>> -# ifndef BUILD_BUG
>
>   Not clear why we get the error if we're protected with #ifndef...

Because this is the first definition. It's redefined later.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>