linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH] MIPS: BCM63XX: add missing include for bcm63xx_gpio.h
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Fri, 03 Feb 2012 14:25:35 +0400
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>, Florian Fainelli <florian@openwrt.org>
In-reply-to: <1328215931-24817-1-git-send-email-jonas.gorski@gmail.com>
References: <1328215931-24817-1-git-send-email-jonas.gorski@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
Hello.

On 03-02-2012 0:52, Jonas Gorski wrote:

bcm63xx_gpio.h uses macros defined in bcm63xx_cpu.h without including it,
leading to the following build failure:

   CC [M]  drivers/mmc/core/cd-gpio.o
In file included from arch/mips/include/asm/mach-bcm63xx/gpio.h:4:0,
                  from arch/mips/include/asm/gpio.h:4,
                  from include/linux/gpio.h:30,
                  from drivers/mmc/core/cd-gpio.c:12:

arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h: In function 
'bcm63xx_gpio_count':
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:10:2: error: implicit 
declaration of function 'bcm63xx_get_cpu_id'
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: error: 'BCM6358_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:11:7: note: each undeclared 
identifier is reported only once for each function it appears in
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:13:7: error: 'BCM6338_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:15:7: error: 'BCM6345_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:17:7: error: 'BCM6368_CPU_ID' 
undeclared (first use in this function)
arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h:19:7: error: 'BCM6348_CPU_ID' 
undeclared (first use in this function)

make[7]: *** [drivers/mmc/core/cd-gpio.o] Error 1

Signed-off-by: Jonas Gorski<jonas.gorski@gmail.com>
---

Looking at the file's history, it looks like the problem was there from
the beginning. So it probably should go into all supported (stable)
versions up to 3.3-rc2, even if this particular build failure popped up
first in 3.3.

   You should then addd "Cc: stable@vger.kernel.org" line after your signoff.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>