[Top] [All Lists]


To: "Michael S. Tsirkin" <>
Subject: Re: [PATCH 1/3] lib: add NO_GENERIC_PCI_IOPORT_MAP
From: Arnd Bergmann <>
Date: Tue, 31 Jan 2012 15:59:25 +0000
Cc: Kevin Cernekee <>, Ralf Baechle <>, Paul Mundt <>, Jesse Barnes <>, Myron Stowe <>, Paul Gortmaker <>, Lucas De Marchi <>, Dmitry Kasatkin <>, James Morris <>, "John W. Linville" <>, Michael Witten <>,,,,
In-reply-to: <>
References: <> <> <>
User-agent: KMail/1.12.2 (Linux/3.3.0-rc1; KDE/4.3.2; x86_64; ; )
On Tuesday 31 January 2012, Michael S. Tsirkin wrote:
> I have an idea: we can make the generic one inline
> if we keep it in the .c file. So something like
> the below on top of my patch will probably work.
> Ack?

IMHO this is still worse than the macro, because it breaks common practice.
The common way to do this is #ifdef/#else/#endif in the header file to
provide either an extern or a macro/inline definition, while having the
inline definition in a separate place makes it harder to understand
what's going on. E.g. a frequent review comment is to not put extern
declarations inside of #ifdef, but if someone tries that here, it would

You also still need the #ifdef in the implementation file, which we
try to avoid normally just like we try to avoid macros where possible.


<Prev in Thread] Current Thread [Next in Thread>