linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Fix duplicate instances of ARCH_SPARSEMEM_ENABLE

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH] MIPS: Fix duplicate instances of ARCH_SPARSEMEM_ENABLE
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 30 Jan 2012 09:03:04 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=0Fz3HIz3jZEZlUuClcwvxGbnLR+n2pq8L4fFjgLwGf0=; b=qGmZ7W58SFl0re+FZAMdtk1rfcJfXtOh199LNO/Ozbin2Z4PFNh24tgmRaCHzCihTb 9FYmngUqdL38fgE6EFBkNyQnSfyX8CPw01MF0zkXo0QA1yyPdaBVZtdcW3QlyzQCqj/k KN5ImrwUVZSa1o97nfXmlgL30QXneiEIANJdE=
In-reply-to: <0736d2becb10905c35eec74f04c63970@localhost>
References: <0736d2becb10905c35eec74f04c63970@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 01/28/2012 03:07 PM, Kevin Cernekee wrote:
"config ARCH_SPARSEMEM_ENABLE" exists in both arch/mips/Kconfig and
arch/mips/cavium-octeon/Kconfig, but the dependencies are not the same.
This results in warnings when a non-Cavium platform tries to select
ARCH_SPARSEMEM_ENABLE:

     $ make lemote2f_defconfig ARCH=mips
     warning: (LEMOTE_FULOONG2E&&  LEMOTE_MACH2F) selects ARCH_SPARSEMEM_ENABLE 
which has unmet direct dependencies (CPU_CAVIUM_OCTEON)
     warning: (LEMOTE_FULOONG2E&&  LEMOTE_MACH2F) selects ARCH_SPARSEMEM_ENABLE 
which has unmet direct dependencies (CPU_CAVIUM_OCTEON)
     #
     # configuration written to .config
     #

Proposed workaround is to use a Cavium-specific config option which
"select"s the desired options.

Signed-off-by: Kevin Cernekee<cernekee@gmail.com>
---
  arch/mips/cavium-octeon/Kconfig |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
index f9e275a..eda8266 100644
--- a/arch/mips/cavium-octeon/Kconfig
+++ b/arch/mips/cavium-octeon/Kconfig
@@ -82,8 +82,9 @@ config CAVIUM_OCTEON_LOCK_L2_MEMCPY
        help
          Lock the kernel's implementation of memcpy() into L2.

-config ARCH_SPARSEMEM_ENABLE
+config CAVIUM_OCTEON_SPARSEMEM_ENABLE
        def_bool y
+       select ARCH_SPARSEMEM_ENABLE
        select SPARSEMEM_STATIC

  config IOMMU_HELPER

NAK!

A cleaner patch for this was already done here:

http://patchwork.linux-mips.org/patch/3285/

<Prev in Thread] Current Thread [Next in Thread>