| To: | Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | [PATCH 3/3] MIPS: Alchemy: handle db1200 cpld ints as they come in |
| From: | Manuel Lauss <manuel.lauss@googlemail.com> |
| Date: | Sat, 21 Jan 2012 18:13:15 +0100 |
| Cc: | Manuel Lauss <manuel.lauss@googlemail.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=hm4w709c0JsAoNDi6LeDezDZgaoIg87Wgx1H4HE6QGI=; b=pLAvwtP0zJzWaMVNdxhlTHA2CEdYYAoPYneuv6Wg7PxTGqcQDuIZuzRI9kSmTpmo3+ Y1sArhV1vGACURaj4Vr6daJac61cIYwSxdo8laoVN9LwzhEkGFSRnSpERtSnzMrjk/IS u19sviwQRY7LEWTJyeFobc4WnZadQhspriy2o= |
| In-reply-to: | <1327165995-27425-1-git-send-email-manuel.lauss@googlemail.com> |
| References: | <1327165995-27425-1-git-send-email-manuel.lauss@googlemail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
Remove the loop in the cascade handler and instead unconditionally
handle just the first set interrupt coming from the CPLD.
This gets rid of a lot of spurious interrupts being triggered for
the SMSC91111 ethernet chip especially under high(er) IDE load:
"eth0: spurious interrupt (mask = 0xb3)"
Verified on DB1200 and DB1300.
Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
---
arch/mips/alchemy/devboards/bcsr.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/mips/alchemy/devboards/bcsr.c
b/arch/mips/alchemy/devboards/bcsr.c
index 1e83ce2..f2039ef 100644
--- a/arch/mips/alchemy/devboards/bcsr.c
+++ b/arch/mips/alchemy/devboards/bcsr.c
@@ -90,10 +90,7 @@ static void bcsr_csc_handler(unsigned int irq, struct
irq_desc *d)
unsigned short bisr = __raw_readw(bcsr_virt + BCSR_REG_INTSTAT);
disable_irq_nosync(irq);
-
- for ( ; bisr; bisr &= bisr - 1)
- generic_handle_irq(bcsr_csc_base + __ffs(bisr));
-
+ generic_handle_irq(bcsr_csc_base + __ffs(bisr));
enable_irq(irq);
}
--
1.7.8.4
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/3] MIPS: Alchemy: devboards: kill prom.c, Manuel Lauss |
|---|---|
| Next by Date: | Re: [PATCH 1/1] mm: msync: fix issues of sys_msync on tmpfs, Hugh Dickins |
| Previous by Thread: | [PATCH 2/3] MIPS: Alchemy: devboards: kill prom.c, Manuel Lauss |
| Next by Thread: | [PATCH 0/7] EHCI and OHCI for bcma and ssb, Hauke Mehrtens |
| Indexes: | [Date] [Thread] [Top] [All Lists] |