| To: | Stephen Hemminger <shemminger@vyatta.com> |
|---|---|
| Subject: | Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery |
| From: | Joshua Kinard <kumba@gentoo.org> |
| Date: | Tue, 27 Dec 2011 17:48:32 -0500 |
| Cc: | netdev@vger.kernel.org, Linux MIPS List <linux-mips@linux-mips.org> |
| In-reply-to: | <20111227143441.30d2c42f@nehalam.linuxnetplumber.net> |
| References: | <4EED3A3D.9080503@gentoo.org> <4EF95247.7000403@gentoo.org> <20111227103408.01aad10e@nehalam.linuxnetplumber.net> <4EFA38D5.1000602@gentoo.org> <20111227143441.30d2c42f@nehalam.linuxnetplumber.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (Windows NT 6.0; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
On 12/27/2011 17:34, Stephen Hemminger wrote: > On Tue, 27 Dec 2011 16:29:57 -0500 > Joshua Kinard <kumba@gentoo.org> wrote: > >> MIPS I/O registers are always memory-mapped, and to prevent the compiler >> from trying to over-optimize, volatile is used to make sure we always read a >> value from the hardware and not from some cached value. > > Almost every other network driver had memory mapped register. > The problem is volatile is that the compiler is stupid and wrong. > Using explicit barriers is preferred and ensures correct and fast > code. I am somewhat new to driver development, so I do not know all the tricks of the trade just yet. Do you have references to doing explicit barriers that I can look at? Might be worth trying on the RTC driver I have to get the hang of them. -- Joshua Kinard Gentoo/MIPS kumba@gentoo.org 4096R/D25D95E3 2011-03-28 "The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost in that vast, terrible in-between." --Emperor Turhan, Centauri Republic |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery, Stephen Hemminger |
|---|---|
| Next by Date: | Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery, Stephen Hemminger |
| Previous by Thread: | Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery, Stephen Hemminger |
| Next by Thread: | Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |